From owner-freebsd-current@FreeBSD.ORG Wed Jan 30 20:35:12 2008 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8F16516A417 for ; Wed, 30 Jan 2008 20:35:12 +0000 (UTC) (envelope-from ndenev@gmail.com) Received: from rv-out-0910.google.com (rv-out-0910.google.com [209.85.198.186]) by mx1.freebsd.org (Postfix) with ESMTP id DC65A13C45A for ; Wed, 30 Jan 2008 20:35:11 +0000 (UTC) (envelope-from ndenev@gmail.com) Received: by rv-out-0910.google.com with SMTP id g13so328102rvb.43 for ; Wed, 30 Jan 2008 12:35:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition:x-google-sender-auth; bh=aiAnmltHZEyYKUd3KjhlDDjoJynCvzWI6MElEbDq324=; b=E8Pv2tI1JfNVCa0aW0G/KRA7sIqrQI3cgPxLlVkS/gZwgEUzjhT3I1/m4LDtKgfJHFmIkfGxbx1XUPj7myEX7mi0aXe6WxeMkKs3axLNmlmdEYFkg8ZADUOHuYWaffjl8Wohvz7SLeudyTMR25y27YQhu/GEOb2sCJdUr0fdQYA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition:x-google-sender-auth; b=IosgBIf63RQ7S4PdFCBpkMwqv974+idaPNvFjL4DH4W9n3c9zh+jkgAFZMgb4MQ7AIioD3SUHywo+fvlu6jIIG06jjhM/9TFSfj88j9M39pAXRw/lRtpzQxuDM5RxW/Jwd4zPV4UaHtShZdy/gWXlglnQVKkd1SvwS2vSf9hpus= Received: by 10.140.185.19 with SMTP id i19mr803772rvf.296.1201723681221; Wed, 30 Jan 2008 12:08:01 -0800 (PST) Received: by 10.141.170.18 with HTTP; Wed, 30 Jan 2008 12:08:01 -0800 (PST) Message-ID: <2e77fc10801301208s5954572ck72a9a04be4d6bef3@mail.gmail.com> Date: Wed, 30 Jan 2008 22:08:01 +0200 From: "Niki Denev" Sender: ndenev@gmail.com To: freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline X-Google-Sender-Auth: ed6b60415369f002 Subject: [patch] unable to remount/update gjournaled fs with "current" option X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2008 20:35:12 -0000 Hello, I'm not sure if this is the right place for this, but probably we want this fixed before 7.0-RELEASE as it is the release that introduces geom_journal and it seems likely that this bug will be hit often. In short : When doing mount update with "current" option, mount(8) treats "gjournal" as mount option and tries to apply it. But "gjournal" is a flag, and not an mount option. This also affects "mount -p" case, where mount prints it's output in fstab compatible format. Filed as [bin/120162] : http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/120162 Patch is in the PR and here : http://bg.freebsd.org/~ndenev/src/mount.c.patch -- Niki