From owner-cvs-all@FreeBSD.ORG Mon Aug 21 11:08:01 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BD21616A4DA; Mon, 21 Aug 2006 11:08:01 +0000 (UTC) (envelope-from kris@obsecurity.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id E9ADB43D70; Mon, 21 Aug 2006 11:07:54 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (elvis.mu.org [192.203.228.196]) by elvis.mu.org (Postfix) with ESMTP id D1A4D1A4E0A; Mon, 21 Aug 2006 04:07:54 -0700 (PDT) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id DBC5351619; Mon, 21 Aug 2006 07:07:53 -0400 (EDT) Date: Mon, 21 Aug 2006 07:07:53 -0400 From: Kris Kennaway To: "Raphael H. Becker" Message-ID: <20060821110753.GA99959@xor.obsecurity.org> References: <200601161951.k0GJpfNx017833@repoman.freebsd.org> <20060821080945.A48690@p-i-n.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qMm9M+Fa2AknHoGS" Content-Disposition: inline In-Reply-To: <20060821080945.A48690@p-i-n.com> User-Agent: Mutt/1.4.2.2i Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, Florent Thoumie Subject: Re: PKGDIR ambiguous (was: cvs commit: src/usr.sbin/pkg_install/info info.h main.c perform.c pkg_info.1 src/usr.sbin/pkg_install/add add.h main.c perform.c pkg_add.1 src/usr.sbin/pkg_install/lib lib.h url.c) X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Aug 2006 11:08:01 -0000 --qMm9M+Fa2AknHoGS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 21, 2006 at 08:09:45AM +0200, Raphael H. Becker wrote: >=20 > Hi Florent, >=20 > PKGDIR is ambiguous in the context of ports and packages. >=20 > I set PKGDIR=3D/some/where/my/pkg in my /etc/profile which causes the > ports to fail badly creating any packages: >=20 > It is used in ports/Mk/bsd.port.mk: > # PKGDIR - A directory containing any package creation > # files. > # Default: ${MASTERDIR} > [...] > PKGDIR?=3D ${MASTERDIR} >=20 > Havin set PKGDIR statically is a very bad idea here. Yes, PKGDIR is incorrect in this usage. The documented place where packages are stored is: # PACKAGES - A top level directory where all packages go (rath= er than # going locally to each port). # Default: ${PORTSDIR}/packages # > > flz 2006-01-16 19:51:41 UTC > >=20 > > FreeBSD src repository (ports committer) > >=20 > > Modified files: (Branch: RELENG_5) > > usr.sbin/pkg_install/info perform.c pkg_info.1 info.h main.c=20 > > usr.sbin/pkg_install/add main.c add.h pkg_add.1 perform.c=20 > > usr.sbin/pkg_install/lib lib.h url.c=20 > > Log: > > MFC: > > =20 > > Add -K option to pkg_add and pkg_info. > > This option saves packages to PKGDIR (if defined or current directo= ry by default) > > as they are downloaded. --qMm9M+Fa2AknHoGS Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFE6ZQJWry0BWjoQKURAh2PAJ4k5pAjhz6u+7bTJ5qVXUW9hoBEfACgmEVs WoPSKbyXkgFYUpvFQFhEX84= =6OBB -----END PGP SIGNATURE----- --qMm9M+Fa2AknHoGS--