From owner-cvs-all Fri Jul 23 10:36:37 1999 Delivered-To: cvs-all@freebsd.org Received: from gndrsh.aac.dev.com (GndRsh.aac.dev.com [198.145.92.4]) by hub.freebsd.org (Postfix) with ESMTP id 0E58814CAE; Fri, 23 Jul 1999 10:36:02 -0700 (PDT) (envelope-from rgrimes@gndrsh.aac.dev.com) Received: (from rgrimes@localhost) by gndrsh.aac.dev.com (8.9.3/8.9.3) id KAA88336; Fri, 23 Jul 1999 10:34:09 -0700 (PDT) (envelope-from rgrimes) From: "Rodney W. Grimes" Message-Id: <199907231734.KAA88336@gndrsh.aac.dev.com> Subject: Re: cvs commit: src/release/sysinstall tcpip.c In-Reply-To: <33651.932717458@critter.freebsd.dk> from Poul-Henning Kamp at "Jul 23, 1999 10:10:58 am" To: phk@critter.freebsd.dk (Poul-Henning Kamp) Date: Fri, 23 Jul 1999 10:34:08 -0700 (PDT) Cc: mike@smith.net.au (Mike Smith), jeremyp@gsmx07.alcatel.com.au (Peter Jeremy), cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, jkh@FreeBSD.org X-Mailer: ELM [version 2.4ME+ PL54 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk > > I would advocate the ether_input API. I have never heard of a 3rd > party ethernet driver, and considering the number of changes we > introduce between 3.x and 4.x anyway, driver compatibility is > already pretty much shot anyway, so I think we should fix the > API to do it "right" rather than fight for a compatibility which > is at best of only marginal advantage to anybody. What about ET Inc's wan cards, if I recall Dennis screams everytime FreeBSD changes the network layer API. Though moving bpf up a layer would simplfy things for him in the long run (no reason to ship 2 driver .o files, one without BPF and one with), he'll still probably complain. These changes would probably effect all network devices... So there you have it, your never heard of 3rd party driver. > > Poul-Henning > > In message <199907230030.RAA03011@dingo.cdrom.com>, Mike Smith writes: > >> That is really a deficiency of our ethernet layer (on my todo-list > >> way down there...) Each ethernet driver shouldn't have to know > >> as much as it does about the input path for packets, or for that > >> matter if bpf is there or not. > > > >The basic problem here is that bpf et. al. want the whole datagram, > >while ether_input wants it broken up into the header and body. > > > >There are two approaches we can take here; either we change ether_input > >to take the raw packet (alters the driver API) or we shim bpf to > >reconstruct the packet. > > -- > Poul-Henning Kamp FreeBSD coreteam member > phk@FreeBSD.ORG "Real hackers run -current on their laptop." > FreeBSD -- It will take a long time before progress goes too far! > > -- Rod Grimes - KD7CAX - (RWG25) rgrimes@gndrsh.dnsmgr.net To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message