From owner-freebsd-current@FreeBSD.ORG Tue Mar 5 18:15:44 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id C65F89C1 for ; Tue, 5 Mar 2013 18:15:44 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) by mx1.freebsd.org (Postfix) with ESMTP id 104083C4 for ; Tue, 5 Mar 2013 18:15:43 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.6/8.14.6) with ESMTP id r25IFcCH034542; Tue, 5 Mar 2013 20:15:38 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.8.0 kib.kiev.ua r25IFcCH034542 Received: (from kostik@localhost) by tom.home (8.14.6/8.14.6/Submit) id r25IFc0a034541; Tue, 5 Mar 2013 20:15:38 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 5 Mar 2013 20:15:38 +0200 From: Konstantin Belousov To: Jean-S?bastien P?dron Subject: Re: r247835: drm2 code breaks buildkernel Message-ID: <20130305181538.GJ3794@kib.kiev.ua> References: <5135C70B.50906@zedat.fu-berlin.de> <5135CD0E.8040801@dumbbell.fr> <5135DE36.9010303@zedat.fu-berlin.de> <20130305123016.GE1483@glenbarber.us> <5135FD78.1050608@FreeBSD.org> <20130305153736.GH3794@kib.kiev.ua> <51362002.2060906@dumbbell.fr> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="oplxJGu+Ee5xywIT" Content-Disposition: inline In-Reply-To: <51362002.2060906@dumbbell.fr> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home Cc: freebsd-current@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Mar 2013 18:15:44 -0000 --oplxJGu+Ee5xywIT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 05, 2013 at 05:40:34PM +0100, Jean-S?bastien P?dron wrote: > On 05.03.2013 16:37, Konstantin Belousov wrote: > > The patch below is supposed to fix double declaration (it is pathetic t= hat > > clang silently accepts this, while issuing countless useless warnings). > > Also there is a usual workaround for the anonimous union/struct issue. >=20 > What do you think about "-fms-extensions"? It avoids modifications to > the code and works with both gcc and clang. Since TTM code needs a lot of modifications anyway, I do not mind to make one more local change. I already did it, please see r247849. This is IMO better then getting more unhandled warnings. >=20 > There're several unnamed structs/unions in the radeon code too. I would > like to keep the diff with Linux code as small as possible. It is your call. I am only looking after the TTM right now. --oplxJGu+Ee5xywIT Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQIcBAEBAgAGBQJRNjZJAAoJEJDCuSvBvK1BAdkP/1oD5Sw0CIBghNCXOJ/JqLDk a77MCIw9ROQRKF5PyZ6/WBlH1D8Ihr1fkzsGQun8yHr+T0odem6sijEDf9lovLLw rjtec7wSpFwkxV3kCodqpAL4ArN+wJd2uDg8b8vW+MAYg4q0hgXWLUtAIhvsoXYx s6sCUqYfQiajDN4H2pP72Ga3/IrS6S1HmMMEzHYYVf1ScqiWE8bZ/xQiN2mCI6TI R4Lxmr+F8Bj4/opHXRwaLq/FunjaXM4HNLaAEipbR7eTegzNYxTrHnqWhykPggM/ jkDOG2b1ZWvERfc1gQzzGcpxbP8dlg7rajpE3jFEyb4WSb8cxn8vXSi+FOdPIksQ VYQlHaKJ3C3Ef7R2iRWzyuvOy5yYkmI8QCf8oU+bsoiYK97zgk26pmLeajfisUsI 2OHmJGw4cWc7ZuNnXYlidc5d373KFfEm6rTmJMzucEoDzLsjsvYTxitlvLKKXQWb GORb4t9rXkjahwgkA2xL1Ai5ioLNenv3CiwBw0/Lew8LiAXQ/It3omh7t/hqzpwQ Kb7A+Bi2T/1LYEvpjzVv9VoOAssDm2u9cH8iidJ9z2AR7UozFEsN1Ktza5B8XPir 9jfF+03eOb1vUMFwA/Ma9+DTlBu0WPVt3NyxzakblmtDhG60BKR9E7KT8BwemxIW 07v6IXa9bvHtC7cAODis =kiGj -----END PGP SIGNATURE----- --oplxJGu+Ee5xywIT--