From owner-freebsd-current Fri Jul 2 21:59:41 1999 Delivered-To: freebsd-current@freebsd.org Received: from feral.com (feral.com [192.67.166.1]) by hub.freebsd.org (Postfix) with ESMTP id B008614C7F for ; Fri, 2 Jul 1999 21:59:39 -0700 (PDT) (envelope-from mjacob@feral.com) Received: from semuta.feral.com (semuta [192.67.166.70]) by feral.com (8.8.7/8.8.7) with ESMTP id VAA01856; Fri, 2 Jul 1999 21:59:31 -0700 Date: Fri, 2 Jul 1999 21:59:02 -0700 (PDT) From: Matthew Jacob Reply-To: mjacob@feral.com To: "Brian F. Feldman" Cc: Greg Lehey , current@FreeBSD.ORG Subject: Re: Fixing other people's code (was: world broken in vinum (PATCH)) In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > > > > > > If it's really blocking folks because things don't compile, it is always > > > acceptable to do what you need to do- the tree should always compile even > > > if -current. If the system doesn't boot because of change, then that's an > > > obvious one too. If things work differently or not as well, but things > > > are more or less working, it's not an emergency, so leave it for the > > > author to fix.... > > > > ...always modulo a short delay (call it a couple of hours) after reporting > > the problem... after all, you don't *know* that the update isn't finished > > and that other things are coming down the pipe... but a couple of hours > > leaves really the most reasonable time for an integration to complete and > > the author to have had lunch in between. > > > > I worded my original post wrong; my change did fix world. Your second point > (the "wait and see" approach) wouldn't apply in this case: Greg was asleep, > and world was broken. You have to wait at least a little bit because with CVS there is no atomic update of a set of modules. IF make world is broken, waiting at least a certain period of time and then doing another update is important to ensure that you just simply updated only part of a an active checkin cycle. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message