From owner-svn-src-all@freebsd.org Tue Aug 25 11:06:14 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ADBE599A7E0; Tue, 25 Aug 2015 11:06:14 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-wi0-x235.google.com (mail-wi0-x235.google.com [IPv6:2a00:1450:400c:c05::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D7DFFF; Tue, 25 Aug 2015 11:06:14 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: by wicja10 with SMTP id ja10so11465998wic.1; Tue, 25 Aug 2015 04:06:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=ZhTUOcB6eHqawX39vFsTDThSP6hReS+7GxacgeO82A0=; b=hDgeq6t0MmPl1CfLMYTYfom2jB5Pbm2LQ5rVJp/0dFgewGe/Q3LuEcfFsdfxp5kRIr 1aSzoiOugYN18dG12sSs4l93zgbWdnjUJIKq5EOmVqriUo6RdnW2xQ+dcncxWMYApqnU nlDGleo7eKTdmm0FDRfUntiyDy+56kPCdJWpvdhPMR4HmuRYev5J9Svz/TRjng9TUqFz CQTEJsxJu8QMn8uiXl4Bo3UxpBlyTbqoQ0X9d1YwmNFvMIKzigPLMYd9XixdjTJnVs5R 4RxyumoOt0Qfvz+otkjkw96PDs6yzuD2vdQ20yo6LRa4OueXP5r8ORrTJsLw0hFvDY6O 1SYw== X-Received: by 10.180.80.200 with SMTP id t8mr3751557wix.18.1440500772694; Tue, 25 Aug 2015 04:06:12 -0700 (PDT) Received: from mavbook.mavhome.dp.ua ([134.249.139.101]) by smtp.googlemail.com with ESMTPSA id ej5sm27530374wjd.22.2015.08.25.04.06.11 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 25 Aug 2015 04:06:11 -0700 (PDT) Sender: Alexander Motin Message-ID: <55DC4C22.4030501@FreeBSD.org> Date: Tue, 25 Aug 2015 14:06:10 +0300 From: Alexander Motin User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Gleb Smirnoff CC: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Subject: Re: svn commit: r287016 - in stable/10: . share/man/man4 sys/arm/mv sys/boot/forth sys/conf sys/dev/ata sys/dev/ata/chipsets sys/modules/ata/atapci/chipsets sys/modules/ata/atapci/chipsets/ataadaptec s... References: <201508220732.t7M7WmJ0053866@repo.freebsd.org> <20150825103701.GL56997@FreeBSD.org> In-Reply-To: <20150825103701.GL56997@FreeBSD.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Aug 2015 11:06:14 -0000 On 25.08.2015 13:37, Gleb Smirnoff wrote: > On Sat, Aug 22, 2015 at 07:32:48AM +0000, Alexander Motin wrote: > A> Author: mav > A> Date: Sat Aug 22 07:32:47 2015 > A> New Revision: 287016 > A> URL: https://svnweb.freebsd.org/changeset/base/287016 > A> > A> Log: > A> MFC r280451: > A> Remove from legacy ata(4) driver support for hardware, supported by newer > A> and more functional drivers ahci(4), siis(4) and mvs(4). > A> > A> This removes about 3400 lines of code, unused since FreeBSD 9.0 release. > > What is the reason to break POLA in stable branch? Reducing diff from head to make later merges easier. > Don't get me wrong. I'm all for removing stale code from head. But is it > worth to hurt someone who runs custom built kernel with 'device ad' and > tracks stable/10? There never was legacy ATA stack in stable/10, so there is no such users. The only POLA breakage here is that people with custom kernels for some reason having only ata driver may now require ahci, siis or mvs. If such cases exist, they are most likely a configuration bugs, as alternative gives NCQ, hot-plug, etc. for free. -- Alexander Motin