From owner-freebsd-ports-bugs@FreeBSD.ORG  Mon Jun 16 12:45:29 2014
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 72F70875
 for <freebsd-ports-bugs@FreeBSD.org>; Mon, 16 Jun 2014 12:45:29 +0000 (UTC)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 404922D39
 for <freebsd-ports-bugs@FreeBSD.org>; Mon, 16 Jun 2014 12:45:29 +0000 (UTC)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.8/8.14.8) with ESMTP id s5GCjTNk032262
 for <freebsd-ports-bugs@FreeBSD.org>; Mon, 16 Jun 2014 13:45:29 +0100 (BST)
 (envelope-from bz-noreply@freebsd.org)
From: bz-noreply@freebsd.org
To: freebsd-ports-bugs@FreeBSD.org
Subject: [Bug 191085] New: [patch] Mk/bsd.options.mk small fix for
 ${opt}_WITH if option is off
Date: Mon, 16 Jun 2014 12:45:29 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Ports Tree
X-Bugzilla-Component: Infrastructure
X-Bugzilla-Version: Latest
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Many People
X-Bugzilla-Who: ohauer@FreeBSD.org
X-Bugzilla-Status: Needs Triage
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-191085-13@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Jun 2014 12:45:29 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191085

            Bug ID: 191085
           Summary: [patch] Mk/bsd.options.mk small fix for ${opt}_WITH if
                    option is off
           Product: Ports Tree
           Version: Latest
          Hardware: Any
                OS: Any
            Status: Needs Triage
          Severity: Affects Many People
          Priority: ---
         Component: Infrastructure
          Assignee: freebsd-ports-bugs@FreeBSD.org
          Reporter: ohauer@FreeBSD.org

The ${opt}_WITH construct is not usable in case the option has additional
parameters like paths 

E.g dns/powerdns uses:

PGSQL_CONFIGURE_ON=     --with-pgsql=${LOCALBASE}
PGSQL_CONFIGURE_OFF=    --without-pgsql
MYSQL_CONFIGURE_ON=     --with-mysql=${LOCALBASE}
MYSQL_CONFIGURE_OFF=    --without-mysql


For testing change the four lines to the following two
PGSQL_CONFIGURE_WITH=     pgsql=${LOCALBASE}
MYSQL_CONFIGURE_WITH=     mysql=${LOCALBASE}

Then test with make -V CONFIGURE_ARGS WITHOUT=PGSQL -C dns/powerdns
... --without-pgsql=/usr/local
-> ${LOCALBASE} is not stripped


With the patch below it works as expected and many Makefiles can be simplified

make -V CONFIGURE_ARGS WITHOUT=PGSQL -C dns/powerdns
... --without-pgsql


Index: /usr/ports/Mk/bsd.options.mk
===================================================================
--- /usr/ports/Mk/bsd.options.mk        (revision 357956)
+++ /usr/ports/Mk/bsd.options.mk        (working copy)
@@ -470,7 +470,7 @@
 .    endif
 .    if defined(${opt}_CONFIGURE_WITH)
 .      for iopt in ${${opt}_CONFIGURE_WITH}
-CONFIGURE_ARGS+=       --without-${iopt}
+CONFIGURE_ARGS+=       --without-${iopt:C/=.*//}
 .      endfor
 .    endif
 .    for configure in CONFIGURE CMAKE QMAKE

-- 
You are receiving this mail because:
You are the assignee for the bug.