From owner-freebsd-ports@FreeBSD.ORG Sat Jan 31 07:35:02 2015 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 78AF616A; Sat, 31 Jan 2015 07:35:02 +0000 (UTC) Received: from ipmail06.adl6.internode.on.net (ipmail06.adl6.internode.on.net [150.101.137.145]) by mx1.freebsd.org (Postfix) with ESMTP id DD0D89C3; Sat, 31 Jan 2015 07:35:00 +0000 (UTC) Received: from ppp118-210-27-239.lns20.adl2.internode.on.net (HELO leader.local) ([118.210.27.239]) by ipmail06.adl6.internode.on.net with ESMTP; 31 Jan 2015 18:04:52 +1030 Message-ID: <54CC859C.3010802@ShaneWare.Biz> Date: Sat, 31 Jan 2015 18:04:52 +1030 From: Shane Ambler User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Jan Beich , Don Lewis Subject: Re: testing the value of ${CXX} in ports Makefile References: <201501300345.t0U3jHwb008745@gw.catspoiler.org> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: ports@FreeBSD.org X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Jan 2015 07:35:02 -0000 On 31/01/2015 15:30, Jan Beich wrote: > Also, the following wouldn't work > > .if ${CHOSEN_COMPILER_TYPE} == "gcc" && ${COMPILER_VERSION} == 49 > > because COMPILER_VERSION or COMPILER_FEATURES are evaluated against > COMPILER_TYPE, not CHOSEN_COMPILER_TYPE. That is a good point, it appears we currently only get the chosen compiler type and not it's version or features. So COMPILER_FEATURES and COMPILER_VERSION should be set against CHOSEN_COMPILER_TYPE as that is the one to be used to build the current port, which would be the one we want to know about when making build decisions. Or at least there should be CHOSEN_COMPILER_FEATURES and CHOSEN_COMPILER_VERSION I have chosen to submit this as a bug report - https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197219 -- FreeBSD - the place to B...Software Developing Shane Ambler