From owner-freebsd-current@FreeBSD.ORG Tue Dec 4 18:14:19 2007 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D7E6A16A417 for ; Tue, 4 Dec 2007 18:14:19 +0000 (UTC) (envelope-from keramida@ceid.upatras.gr) Received: from igloo.linux.gr (igloo.linux.gr [62.1.205.36]) by mx1.freebsd.org (Postfix) with ESMTP id 4E70013C448 for ; Tue, 4 Dec 2007 18:14:19 +0000 (UTC) (envelope-from keramida@ceid.upatras.gr) Received: from kobe.laptop (vader.bytemobile-rio.ondsl.gr [83.235.57.37]) (authenticated bits=128) by igloo.linux.gr (8.14.1/8.14.1/Debian-9) with ESMTP id lB4IDMQe017712 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 4 Dec 2007 20:14:02 +0200 Received: from kobe.laptop (kobe.laptop [127.0.0.1]) by kobe.laptop (8.14.2/8.14.2) with ESMTP id lB4IDHEe063294; Tue, 4 Dec 2007 20:13:17 +0200 (EET) (envelope-from keramida@ceid.upatras.gr) Received: (from keramida@localhost) by kobe.laptop (8.14.2/8.14.2/Submit) id lB4IDHB0063293; Tue, 4 Dec 2007 20:13:17 +0200 (EET) (envelope-from keramida@ceid.upatras.gr) Date: Tue, 4 Dec 2007 20:13:17 +0200 From: Giorgos Keramidas To: obrien@freebsd.org, Luoqi Chen , freebsd-current@freebsd.org, youshi10@u.washington.edu, FreeBSD Release Engineers , Bruce Evans , Alexander Kabaev Message-ID: <20071204181317.GA62240@kobe.laptop> References: <200711292024.lATKOq5R000769@freefall.freebsd.org> <20071129233842.GA57951@ace.netcins.ceid.upatras.gr> <200711292024.lATKOq5R000769@freefall.freebsd.org> <20071130013826.GA66484@kobe.laptop> <20071204175541.GC47398@dragon.NUXI.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071204175541.GC47398@dragon.NUXI.org> X-Hellug-MailScanner: Found to be clean X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-3.998, required 5, autolearn=not spam, ALL_TRUSTED -1.80, AWL 0.40, BAYES_00 -2.60) X-Hellug-MailScanner-From: keramida@ceid.upatras.gr X-Spam-Status: No Cc: Subject: Re: [PATCH] gprof's broken in 7-CURRENT X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Dec 2007 18:14:19 -0000 Given the recent feedback in the lists, yes, that's a better way of handling it. Thanks :) On 2007-12-04 09:55, David O'Brien wrote: > I'm not sure what the action item is. > This looks OK to me - do you want me to commit it to HEAD right now so we > can let it soak a little before discussing it with RE? > > -- David > > On Fri, Nov 30, 2007 at 03:38:27AM +0200, Giorgos Keramidas wrote: > > Please pass this through the release engineering team, Bruce Evans > > (who has the largest number of commits to the file), and our gcc > > folks (David O'Brien, and Alexander Kabaev). > > > > If it is considered safe for RELENG_7 (what will become 7.0-RELEASE), > > then it's probably a good idea to commit it. It looks `harmless' to me, > > but it certainly won't harm to get a proper review from much more > > experienced people (added to the Cc: list). > > > > It would be marvellous to have non-broken profiling in 7.0. > > > > - Giorgos > > > > On 2007-11-30 01:38, Nikos Ntarmos wrote: > > > I couldn't wait for Garrett :) so I went on and tested your patch and > > > gprof seems to work fine for me (at least for the executables I was > > > interested in profiling anyway). This is i386 on a 7.0-BETA3 kernel and > > > 7.0-BETA1 world. What are the chances for this to be committed in time > > > for 7.0R? > > > > On 2007-11-29 20:24, Luoqi Chen wrote: > > > Garrett, would you like to try out my fix? It's actually quite simple,