From owner-freebsd-current@FreeBSD.ORG Wed Jul 10 16:40:31 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 6F63F230 for ; Wed, 10 Jul 2013 16:40:31 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm25-vm0.bullet.mail.ne1.yahoo.com (nm25-vm0.bullet.mail.ne1.yahoo.com [98.138.91.73]) by mx1.freebsd.org (Postfix) with ESMTP id 0BB181CAE for ; Wed, 10 Jul 2013 16:40:30 +0000 (UTC) Received: from [98.138.101.130] by nm25.bullet.mail.ne1.yahoo.com with NNFMP; 10 Jul 2013 16:34:54 -0000 Received: from [98.138.226.31] by tm18.bullet.mail.ne1.yahoo.com with NNFMP; 10 Jul 2013 16:34:54 -0000 Received: from [127.0.0.1] by smtp202.mail.ne1.yahoo.com with NNFMP; 10 Jul 2013 16:34:54 -0000 X-Yahoo-Newman-Id: 93961.14573.bm@smtp202.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: 3GeI2nEVM1kZc2MiPYe8EJ0SBLKwnWqikgUVptSmxylrBGy jisLimFfd2uB_ohsWWL9kTmnIxUzMGvlIExbL58M3BfSqSJzrpsiExRphaPf MIaEaPxOWKpAmoyIYZ3ve.ykhiiyQgEsPJnSor7A3pQWJOoPb5jBFZG4ymyI ufgFAJQAebRORo4V5eUDTbKTlAeukcekLu8LWIsrl4A4Ii04d7T8AyFyhJjM pQv5HLJdXeJqH_m8k0A1mU_QCAkWRmxzFScGwgdWbCx5gfSe49gHfIPGWwpJ ysgJEetWgTANxGsS_hryt1h.O0ebiNIbp_48JbsGjok9atZnB5i42c46ZpoB uhpbE2jDQSVR9bWGa7oE4Keb.Z6sr_ItuYZle8e_xQOpzZgxff9jQQUeY87b zwJMVo9J_sjlLSxYk9Sb6qb8hvvXH5Gws8DuuAUdDKJ_iejdeVd2F8wiNC8I sbiQy0fGG5ZXjfFl1FA_cK2Ch_curlRbuur.iy0a.A.LIsCQ_8CTq_88.d7O xeQ6UCzYlKgUQgMhXyUO0rWTEDAYmevyTnZjBM5vdqeP_Byr.tZJzQ_U5zWU - X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf X-Rocket-Received: from [192.168.0.102] (pfg@190.157.126.109 with ) by smtp202.mail.ne1.yahoo.com with SMTP; 10 Jul 2013 09:34:54 -0700 PDT Message-ID: <51DD8D2B.60509@FreeBSD.org> Date: Wed, 10 Jul 2013 11:34:51 -0500 From: Pedro Giffuni User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130630 Thunderbird/17.0.7 MIME-Version: 1.0 To: Claude Buisson Subject: Re: (follow-up) "Stale NFS file handle" for NFS exported UFS from r252435 References: <51DD5451.2010801@orange.fr> <51DD6777.90803@orange.fr> <51DD782E.7090503@FreeBSD.org> <51DD7AB1.4090202@orange.fr> In-Reply-To: <51DD7AB1.4090202@orange.fr> Content-Type: multipart/mixed; boundary="------------080203060808070404040503" Cc: rmacklem@freebsd.org, FreeBSD Current X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jul 2013 16:40:31 -0000 This is a multi-part message in MIME format. --------------080203060808070404040503 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 10.07.2013 10:16, Claude Buisson wrote: > On 07/10/2013 17:05, Pedro Giffuni wrote: >> Hello guys; >> >> Thank for finding this, however ... >> > > > >> >> While I understand this change caused the issue and I am willing to >> revert it, >> I think the problem is actually in NFS. At least ext2/3/4 and fuse (so I >> presume >> glusterfs) have unsigned i_gen. >> > > I have the same thinking (and was rather astonished by the success of > my try at > reverting it): there is something somewhere in the NFS code which have > not been > synced with the UFS change. > > It is the reason I CC'ed rmacklem@ > >> Pedro. >> > > Claude Buisson > I found a missing type change. Can you try the attached patch? Cheers, Pedro. --------------080203060808070404040503 Content-Type: text/plain; charset=UTF-8; name="patch-unsigned-ufid_gen" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="patch-unsigned-ufid_gen" Index: sys/ufs/ufs/inode.h =================================================================== --- sys/ufs/ufs/inode.h (revision 253159) +++ sys/ufs/ufs/inode.h (working copy) @@ -180,7 +180,7 @@ u_int16_t ufid_len; /* Length of structure. */ u_int16_t ufid_pad; /* Force 32-bit alignment. */ uint32_t ufid_ino; /* File number (ino). */ - int32_t ufid_gen; /* Generation number. */ + uint32_t ufid_gen; /* Generation number. */ }; #endif /* _KERNEL */ --------------080203060808070404040503--