From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Mar 8 10:40:10 2004 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 709D316A4CE for ; Mon, 8 Mar 2004 10:40:10 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5443D43D41 for ; Mon, 8 Mar 2004 10:40:10 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i28IeAbv070100 for ; Mon, 8 Mar 2004 10:40:10 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.10/8.12.10/Submit) id i28IeAiN070099; Mon, 8 Mar 2004 10:40:10 -0800 (PST) (envelope-from gnats) Resent-Date: Mon, 8 Mar 2004 10:40:10 -0800 (PST) Resent-Message-Id: <200403081840.i28IeAiN070099@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Mikhail Teterin Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DD72216A4CE for ; Mon, 8 Mar 2004 10:35:35 -0800 (PST) Received: from corbulon.video-collage.com (corbulon.video-collage.com [64.35.99.179]) by mx1.FreeBSD.org (Postfix) with ESMTP id 68EA543D1D for ; Mon, 8 Mar 2004 10:35:35 -0800 (PST) (envelope-from mteterin@250-217.customer.cloud9.net) Received: from 250-217.customer.cloud9.net (195-11.customer.cloud9.net [168.100.195.11])i28IZ0bd093487 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 8 Mar 2004 13:35:33 -0500 (EST) (envelope-from mteterin@250-217.customer.cloud9.net) Received: from 250-217.customer.cloud9.net (mteterin@localhost [127.0.0.1]) i28IYtw4000496 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 8 Mar 2004 13:34:55 -0500 (EST) (envelope-from mteterin@250-217.customer.cloud9.net) Received: (from mteterin@localhost)i28IYsM3000495; Mon, 8 Mar 2004 13:34:54 -0500 (EST) (envelope-from mteterin) Message-Id: <200403081834.i28IYsM3000495@250-217.customer.cloud9.net> Date: Mon, 8 Mar 2004 13:34:54 -0500 (EST) From: Mikhail Teterin To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: ports/63937: USE_GETTEXT is too specific X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Mar 2004 18:40:10 -0000 >Number: 63937 >Category: ports >Synopsis: USE_GETTEXT is too specific >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Mon Mar 08 10:40:09 PST 2004 >Closed-Date: >Last-Modified: >Originator: Mikhail Teterin >Release: FreeBSD 5.2-RELEASE i386 >Organization: Virtual Estates, Inc. >Environment: >Description: Most (probably -- all) of the ports declaring USE_GETTEXT don't really care, which version of -lintl they get. If none is currently installed on the system, the latest and greatest, should, of course, be built. But if one is already present (and used by other ports, as is usually the case), there is no need to insist on the latest one to build another port. The simple patch below changes bsd.port.mk to treat a port's declaration of USE_GETTEXT=yes as a sign, that it will accept any library version. A port, which needs a particular feature, not present in the earlier gettext releases, can declare USE_GETTEXT=6 to insist on a particular major number. Some other variables in bsd.port.mk should, probably, get a similar treatment (USE_MESA?)? The current rigidity breaks the good old method of port building through make, forcing (coercing?) the use of good new portupgrade. Its only advantage is that it forces the port build to be closer to that on the ports-cluster -- not too useful, because the download of the cluster-built version of a port is available anyway. >How-To-Repeat: Install the latest release of OS and the ports tree. Build kdebase3. Update the ports tree (through cvsup, for example). Try to build lynx-current -- or anything else that uses gettext. Make(1) will notice, that intl.6 is required and proceed to build it and install it. Upon trying to install, it will fail, because an earlier version is already installed. Portupgrade to the resque (if you happen to know about it)... Why? Lynx does not care, which version of gettext it is going to be linked against. The administrating user should be able to upgrade gettext, when she/he wants to -- not when he/she wants to build another package. >Fix: Index: bsd.port.mk =================================================================== RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v retrieving revision 1.484 diff -U2 -r1.484 bsd.port.mk --- bsd.port.mk 4 Feb 2004 04:27:04 -0000 1.484 +++ bsd.port.mk 8 Mar 2004 18:33:27 -0000 @@ -1669,5 +1669,9 @@ .if defined(USE_GETTEXT) -LIB_DEPENDS+= intl.6:${PORTSDIR}/devel/gettext +. if ${USE_GETTEXT:L} == "yes" +LIB_DEPENDS+= intl:${PORTSDIR}/devel/gettext +. else +LIB_DEPENDS+= intl.${USE_GETTEXT}:${PORTSDIR}/devel/gettext +. endif .endif >Release-Note: >Audit-Trail: >Unformatted: