From owner-cvs-all Fri Jul 23 11: 5:53 1999 Delivered-To: cvs-all@freebsd.org Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.54]) by hub.freebsd.org (Postfix) with ESMTP id C1AAD14C1E; Fri, 23 Jul 1999 11:05:40 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.9.3/8.9.1) id LAA06531; Fri, 23 Jul 1999 11:07:32 -0700 (PDT) (envelope-from sgk) From: Steve Kargl Message-Id: <199907231807.LAA06531@troutmask.apl.washington.edu> Subject: Re: cvs commit: src/usr.sbin/inetd builtins.c In-Reply-To: <199907231745.DAA07915@godzilla.zeta.org.au> from Bruce Evans at "Jul 24, 1999 03:45:47 am" To: bde@zeta.org.au (Bruce Evans) Date: Fri, 23 Jul 1999 11:07:32 -0700 (PDT) Cc: gibbs@caspian.plutotech.com, green@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL54 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk Bruce Evans wrote: > > >semantically limiting the scope of the variable to just the area where it > >is used is, IMO, advantageous from a maintenance standpoint. > > Nevertheless, it is explicitly forbidden in style(9) (except in > "unusually complicated" routines). > Where? I just read style(9), I can only find When declaring variables in functions declare them sorted by size, then in alphabetical order; multiple ones per line are okay. Declaring func- tions inside functions is not recommendable, since their linkage scope is always global. If a line overflows reuse the type keyword. I also note that the "sorted by size" doesn't indicate whether smallest comes first or last (although the example does suggest the order). -- Steve To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message