From owner-freebsd-current@FreeBSD.ORG Mon Jul 19 20:36:38 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 25AE116A4CE for ; Mon, 19 Jul 2004 20:36:38 +0000 (GMT) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id AFA9043D41 for ; Mon, 19 Jul 2004 20:36:37 +0000 (GMT) (envelope-from scottl@freebsd.org) Received: from [192.168.0.12] (g4.samsco.home [192.168.0.12]) (authenticated bits=0) by pooker.samsco.org (8.12.11/8.12.10) with ESMTP id i6JKgb7m055321 for ; Mon, 19 Jul 2004 14:42:37 -0600 (MDT) (envelope-from scottl@freebsd.org) Message-ID: <40FC3090.9060305@freebsd.org> Date: Mon, 19 Jul 2004 14:35:28 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7) Gecko/20040514 X-Accept-Language: en-us, en MIME-Version: 1.0 To: freebsd-current@freebsd.org References: In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=0.0 required=3.8 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on pooker.samsco.org Subject: HEADS UP [Re: thread+preemption stability improvement] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jul 2004 20:36:38 -0000 All, Initial testing of this patch looks very promising. For those that aren't comfortable with patching their sources by hand, note that it was committed to CVS a few hours ago and should be showing up on CVSup very shortly (rev 1.8 of sys/i386/i386/intr_machdep.c is what you want if you are running i386). Please go out and test this as much as possible so that we can determine if futher action is needed. Scott Robert Watson wrote: > On Wed, 30 Jun 2004, John Baldwin wrote: > > >>Try this patch. It fixed all my lockups with xmms in KDE on Friday: > > > This patch causes my SMP and UP tests to succeed with PREEMPTION enabled, > whereas before they rapidly hung. On SMP I see a small (just under 1%) > but consistent improvement in query throughput with MySQL, and on UP I see > a small (just under 1%) but inconsistent decrease in query throughput with > MySQL. The standard deviation on the UP case is almost the same size as > the change, but in the SMP case it's 1/4-1/3 the size of the change, FWIW. > > Can't speak to the latency as the test I'm currently running isn't very > latency sensitive, but was very sensitive to the stability issue. I think > this patch is definitely worth committing ASAP :-). > > Robert N M Watson FreeBSD Core Team, TrustedBSD Projects > robert@fledge.watson.org Principal Research Scientist, McAfee Research > > > >>--- //depot/projects/smpng/sys/i386/i386/intr_machdep.c 2004/07/02 20:28:06 >>+++ //depot/user/jhb/preemption/i386/i386/intr_machdep.c 2004/07/16 20:14:26 >>@@ -204,6 +204,8 @@ >> } >> isrc->is_pic->pic_eoi_source(isrc); >> error = 0; >>+ /* XXX */ >>+ td->td_pflags &= ~TDP_OWEPREEMPT; >> critical_exit(); >> } else { >> /* >> >>-- >>John Baldwin <>< http://www.FreeBSD.org/~jhb/ >>"Power Users Use the Power to Serve" = http://www.FreeBSD.org >> > > > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"