From owner-svn-src-all@FreeBSD.ORG Tue Apr 16 09:03:09 2013 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 18F22FC4; Tue, 16 Apr 2013 09:03:09 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [IPv6:2001:7b8:3a7:1:2d0:b7ff:fea0:8c26]) by mx1.freebsd.org (Postfix) with ESMTP id D43E7D19; Tue, 16 Apr 2013 09:03:08 +0000 (UTC) Received: from spaceball.andric.com (spaceball.andric.com [IPv6:2001:7b8:3a7:0:204:4bff:fe01:de8a]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 54AF55C44; Tue, 16 Apr 2013 11:03:06 +0200 (CEST) Message-ID: <516D13C5.70900@FreeBSD.org> Date: Tue, 16 Apr 2013 11:03:01 +0200 From: Dimitry Andric Organization: The FreeBSD Project User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20100101 Thunderbird/21.0 MIME-Version: 1.0 To: =?UTF-8?B?zpPOuc+Oz4HOs86/z4IgzprOtc+BzrHOvM6vzrTOsc+C?= , Gregory Shapiro Subject: Re: svn commit: r246880 - in head: lib/libsm libexec/mail.local libexec/smrsh share/mk usr.bin/vacation usr.sbin/sendmail References: <201302162017.r1GKHVdY022667@svn.freebsd.org> <87a9ozayzk.fsf@saturn.laptop> In-Reply-To: <87a9ozayzk.fsf@saturn.laptop> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Apr 2013 09:03:09 -0000 On 2013-04-16 06:19, =CE=93=CE=B9=CF=8E=CF=81=CE=B3=CE=BF=CF=82 =CE=9A=CE= =B5=CF=81=CE=B1=CE=BC=CE=AF=CE=B4=CE=B1=CF=82 wrote: > On Sat, 16 Feb 2013 20:17:31 +0000 (UTC), Dimitry Andric wrote: =2E.. >> Since clang 3.2 now has an option to suppress warnings about implic= itly >> promoted K&R parameters, remove the workarounds added for sendmail >> components in r228558. =2E.. > The part of the commit that removes NO_WERROR.clang for usr.sbin/sendma= il/ > breaks the build of Sendmail with -DSASL. I just tried rebuilding Send= mail > with the following in "/etc/make.conf": > > # Build Sendmail with SASL support. > SENDMAIL_CFLAGS ?=3D -I/usr/local/include -DSASL=3D20126 > SENDMAIL_LDFLAGS ?=3D -L/usr/local/lib > SENDMAIL_LDADD ?=3D -lsasl2 > > The warnings that usersmtp.c still triggers when -DSASL is used are: > > : cc -O2 -pipe -I/usr/src/usr.sbin/sendmail/../../contrib/sendmail/src= -I/usr/src/usr.sbin/sendmail/../../contrib/sendmail/include -I. -DNEWDB = -DNIS -DTCPWRAPPERS -DMAP_REGEX -DDNSMAP -DNETINET6 -DSTARTTLS -D_FFR_TLS= _1 -I/usr/local/include -DSASL=3D20126 -std=3Dgnu99 -Qunused-arguments -f= stack-protector -Wsystem-headers -Wno-pointer-sign -Wno-empty-body -Wno-s= tring-plus-int -Wno-tautological-compare -Wno-unused-value -Wno-parenthes= es-equality -Wno-unused-function -Wno-conversion -Wno-switch -Wno-switch-= enum -Wno-knr-promoted-parameter -Wno-parentheses -c /usr/src/usr.sbin/se= ndmail/../../contrib/sendmail/src/usersmtp.c > : /usr/src/usr.sbin/sendmail/../../contrib/sendmail/src/usersmtp.c:1797= :50: warning: incompatible pointer types passing 'void ()' to parameter o= f type 'void (*)(char *, bool, MAILER *, struct > : mailer_con_info *, ENVELOPE *)' [-Wincompatible-pointer-types] > : smtpresult =3D reply(m, mci, e, TimeOuts.to_auth, getsasldata= , NULL, > : ^~~~~~~~~~~ Have you tried the patch I posted here? http://lists.freebsd.org/pipermail/freebsd-current/2013-March/040634.html= If people feel this is the right approach, I am happy to commit it. If people prefer to just shut up warnings, I am happy with that too.