From owner-freebsd-current@FreeBSD.ORG Thu Sep 2 13:33:48 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DF71510656B2 for ; Thu, 2 Sep 2010 13:33:47 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-bw0-f54.google.com (mail-bw0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 68DE68FC18 for ; Thu, 2 Sep 2010 13:33:47 +0000 (UTC) Received: by bwz20 with SMTP id 20so677042bwz.13 for ; Thu, 02 Sep 2010 06:33:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:content-type:content-transfer-encoding; bh=2KphT2SUypyRPk5tSZ0hlXn//7YRuK/FVvQx34VzxNg=; b=FCsCO3ClcSxbk0allknutnPcgm84iM8usfLAC/XvdLLNK+v6uxFssmcTnqZ2OC0voo bPTA5C6LgQP92SYSJD9Oypg4nUjZrcF9W2n8W3VWxXGT8zf2m4ZwWLi2CoeYDqYFy5U5 qNqPwK634y5l66dRBCyvgt3wRzEUCQFWYDQ2w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=sz68w0Ss4qwE57X2+z5VXkbiCvxCXZCoNWZcnxNKWlC5lQGxVbLZPljaHLBQePN54r 4f9AJm/DP6mXEqxG2KiNtP0sg9HQKVFSvoznLgVUoUg7s15i+O+qxm6JaxKCwYJgLlnc uA5pXWKzDu79qAyCJa0Mc1S9qC0xMlI5Topo4= Received: by 10.204.126.92 with SMTP id b28mr6724037bks.47.1283434426513; Thu, 02 Sep 2010 06:33:46 -0700 (PDT) Received: from mavbook.mavhome.dp.ua (pc.mavhome.dp.ua [212.86.226.226]) by mx.google.com with ESMTPS id y2sm420967bkx.8.2010.09.02.06.33.45 (version=SSLv3 cipher=RC4-MD5); Thu, 02 Sep 2010 06:33:45 -0700 (PDT) Sender: Alexander Motin Message-ID: <4C7FA7AB.4010905@FreeBSD.org> Date: Thu, 02 Sep 2010 16:33:31 +0300 From: Alexander Motin User-Agent: Thunderbird 2.0.0.24 (X11/20100402) MIME-Version: 1.0 To: bf1783@gmail.com References: In-Reply-To: X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-current@FreeBSD.org Subject: Re: One-shot-oriented event timers management X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Sep 2010 13:33:48 -0000 b. f. wrote: > In: > http://people.freebsd.org/~mav/timers_oneshot7.patch > > you need to offset the declaration of 'cpu' in getnextevent() on line > 256 of src/sys/kern/kern_clocksource.c by #ifdef SMP, because it is > not used otherwise, and will break UP kernel builds with our default > warnings and -Werror. Thanks. > Incidentally, do you intend to commit the tm6292_idle.patch along with > the new timer code, after testing is satisfactory? Or is this not > appropriate for general use? If it isn't suitable for all users, > perhaps some of the periods of the events in that patch can be > abstracted and made tunable, so that we can make it possible to > conserve power, and also keep others happy? No, I am not going to commit it in present form. It is mostly made for technology preview. May be some parts of it could be committed as-is, but most of others are dirty hacks. I hope they should be safe enough, but they made with assumption of some tradeoffs and require proper rework or at least reevaluating. It would be nice if people aware with these areas (SCHED_ULE, TCP, CPU time resources, yarrow, console, GEOM) could review and reimplement them properly. -- Alexander Motin