From owner-freebsd-ports@FreeBSD.ORG Fri Mar 28 21:00:17 2014 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AF3859C6 for ; Fri, 28 Mar 2014 21:00:17 +0000 (UTC) Received: from lor.one-eyed-alien.net (lor.one-eyed-alien.net [69.66.77.232]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5D93D1EF for ; Fri, 28 Mar 2014 21:00:16 +0000 (UTC) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.14.7/8.14.7) with ESMTP id s2SL0EQ4022580; Fri, 28 Mar 2014 16:00:14 -0500 (CDT) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.14.7/8.14.7/Submit) id s2SL0EWI022579; Fri, 28 Mar 2014 16:00:14 -0500 (CDT) (envelope-from brooks) Date: Fri, 28 Mar 2014 16:00:14 -0500 From: Brooks Davis To: "A.J. 'Fonz' van Werven" Subject: Re: Mysterious patches Message-ID: <20140328210014.GE12685@lor.one-eyed-alien.net> References: <20140328201121.GA2505@spectrum.skysmurf.nl> <20140328204754.GA5208@spectrum.skysmurf.nl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="mSxgbZZZvrAyzONB" Content-Disposition: inline In-Reply-To: <20140328204754.GA5208@spectrum.skysmurf.nl> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Henry Hu , "freebsd-ports@freebsd.org" X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Mar 2014 21:00:17 -0000 --mSxgbZZZvrAyzONB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 28, 2014 at 09:47:54PM +0100, A.J. 'Fonz' van Werven wrote: > Henry Hu wrote: >=20 > > They apply to src/raster-png.cxx and src/raster.cxx >=20 > Note to self: look inside the actual patch files themselves, it says right > there which files they apply to *oops*. >=20 > However, this does leave me puzzled about the file names. If a patch > applies to, say, src/foo/bar.c, shouldn't it be called > files/patch-src__foo__bar.c? This is how it's described in the Porter's > Handbook. Given a filename such as files/patch-png.cxx I would expect that > patch to apply to a file ${WRKDIR}/png.cxx. >=20 > What am I misunderstanding here? The rule hasn't been around forever. It's also inappropriate for some types of patches that apply to multiple files and might be removed later. The warning patch is a boarderline example of the latter, but I use the pattern in the clang and llvm ports for patches pulled from the upstream svn repo. New ports should follow the rule where it makes sense, but renaming files used to be annoyingly expensive so older ports were typically left alone. -- Brooks --mSxgbZZZvrAyzONB Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iKYEARECAGYFAlM14t1fFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl bnBncC5maWZ0aGhvcnNlbWFuLm5ldDY1NUQ1MTlDMjZBNzgyRTcyNTI5OUJGMDVE OEU4QkU5RjIzODFBRDQACgkQXY6L6fI4GtTHXACeP1cIf69xVQdFhi4cRPEOS8Cw EKIAn3CjXqj7JYJrZUXpG3R755a3qnbZ =tZ1s -----END PGP SIGNATURE----- --mSxgbZZZvrAyzONB--