From owner-freebsd-ports@FreeBSD.ORG  Fri Jul 20 07:35:12 2012
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 746B5106564A;
	Fri, 20 Jul 2012 07:35:12 +0000 (UTC)
	(envelope-from utisoft@gmail.com)
Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com
	[209.85.214.54])
	by mx1.freebsd.org (Postfix) with ESMTP id C57508FC1C;
	Fri, 20 Jul 2012 07:35:11 +0000 (UTC)
Received: by bkcje9 with SMTP id je9so3237569bkc.13
	for <multiple recipients>; Fri, 20 Jul 2012 00:35:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:sender:in-reply-to:references:from:date
	:x-google-sender-auth:message-id:subject:to:cc:content-type;
	bh=wjmbR1Tz/yq7sSNtTO83tT8SiJFzuP/shcdQFSlrBC8=;
	b=VC3E71tcxjMVX1jjNpYe+VEfdXu78MZ4hLzGxxFyI5mU8lOKb6BMqIE3m82FXcvT2I
	g18tXGTqV7fW634gGDBB1+L9dG5bAB1Xd+EIn+YvirkeekSlNG1RW3yyhsFbMGoLeh0b
	OdjgaFlDxZXJZWhOKGvD4j0nXptPlXn8DVp0DueqCbnxfx5HftUcDaSdrEbKdrjZqFV6
	fl4i8upt8IUHc/yTZk8JUUZnPxtpNWNrUFl2/rkgIe5dVG2xMF/HUTCpOtfvuN1jJcZD
	q7Iv1PQAL8EhQ3W5v0uIKdK2h98k9ujCEdPhb468XjtG3rgDCh4YrqoharJeB7CSg7rv
	A+Lg==
Received: by 10.205.134.137 with SMTP id ic9mr2212276bkc.57.1342769710822;
	Fri, 20 Jul 2012 00:35:10 -0700 (PDT)
MIME-Version: 1.0
Sender: utisoft@gmail.com
Received: by 10.204.49.87 with HTTP; Fri, 20 Jul 2012 00:34:40 -0700 (PDT)
In-Reply-To: <20120719170401.GA19240@DataIX.net>
References: <20120719170401.GA19240@DataIX.net>
From: Chris Rees <crees@FreeBSD.org>
Date: Fri, 20 Jul 2012 08:34:40 +0100
X-Google-Sender-Auth: lputo_-qaUtQLpBzi2iqcVNTH7M
Message-ID: <CADLo83_DmydVWOyd-UBYTtzzNPfnmUYVbhsD6fzr5fBT5nKmMg@mail.gmail.com>
To: Jason Hellenthal <jhellenthal@dataix.net>
Content-Type: text/plain; charset=ISO-8859-1
Cc: ports@freebsd.org, timur@freebsd.org
Subject: Re: SAMBA_PORT= usage different by port.
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Jul 2012 07:35:12 -0000

On 19 July 2012 18:04, Jason Hellenthal <jhellenthal@dataix.net> wrote:
>
> It seems that the usage of SAMBA_PORT= var has been confused quite a
> bit.
>
> SAMBA_PORT= as judged by ports/net/samba* is defined to be "net/samba??"
> while ports/net/samba-libsmbclient defines it as "samba??"
>
> I found when creating index that no matter which way you define it both
> of the two ways will end up indicating failure for different ports
> because /usr/ports/samba?? does not exist or /usr/ports/net/net/samba??
> does not exist.
>
> Can someone please go through these ports and unify there usage of
> SAMBA_PORT.
>
> /usr/ports/net/samba-libsmbclient/Makefile:16:SAMBA_PORT=               samba34
> /usr/ports/net/samba-libsmbclient/Makefile:19:MASTERDIR=                ${.CURDIR}/../${SAMBA_PORT}
> /usr/ports/net/samba-nmblookup/Makefile:16:SAMBA_PORT=          samba34
> /usr/ports/net/samba-nmblookup/Makefile:19:MASTERDIR=           ${.CURDIR}/../${SAMBA_PORT}
> /usr/ports/net/samba-pdbsql/Makefile:23:SAMBA_PORT?=            net/samba34
> /usr/ports/net/samba-pdbsql/Makefile:30:SAMBA_WRKSRC!=          cd ${PORTSDIR}/${SAMBA_PORT} && ${MAKE} -V WRKSRC
> /usr/ports/net/samba-pdbsql/Makefile:34:SAMBA_MODULEDIR!=       cd ${PORTSDIR}/${SAMBA_PORT} && ${MAKE} -V SAMBA_MODULEDIR
> /usr/ports/net/samba-pdbsql/Makefile:40:BUILD_DEPENDS+=         ${NONEXISTENT}:${PORTSDIR}/${SAMBA_PORT}:configure
> /usr/ports/net/samba-smbclient/Makefile:16:SAMBA_PORT=          samba36
> /usr/ports/net/samba-smbclient/Makefile:21:MASTERDIR=           ${.CURDIR}/../${SAMBA_PORT}
> /usr/ports/net/samba4-devel/Makefile:7:PORTNAME?=               ${SAMBA_PORTNAME}
> /usr/ports/net/samba4-devel/Makefile:23:SAMBA_PORTNAME=         samba4
> /usr/ports/net/samba4-devel/Makefile:25:SAMBA_DISTNAME=         ${SAMBA_PORTNAME:S|4$||}-${SAMBA_VERSION:S|.p|pre|:S|.r|rc|:S|.t|tp|:S|.a|alpha|}
> /usr/ports/net/samba4-devel/Makefile:26:OPTIONSFILE=            ${PORT_DBDIR}/${SAMBA_PORTNAME}/options
> /usr/ports/net/samba4-devel/Makefile:187:USE_RC_SUBR=           ${SAMBA_PORTNAME}

I've usually seen category/port used.

I'm sure Timur will have a look, but for quicker results you could
send a PR with a patch.

Chris