From owner-cvs-all@FreeBSD.ORG Mon Oct 18 17:35:33 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1756716A4CE; Mon, 18 Oct 2004 17:35:33 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 611E643D31; Mon, 18 Oct 2004 17:35:32 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9IHZV0C096982; Mon, 18 Oct 2004 20:35:31 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 32335-14; Mon, 18 Oct 2004 20:35:30 +0300 (EEST) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9IHZNM3096978; Mon, 18 Oct 2004 20:35:26 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.1/8.13.1) id i9IHZGs8089792; Mon, 18 Oct 2004 20:35:16 +0300 (EEST) (envelope-from ru) Date: Mon, 18 Oct 2004 20:35:16 +0300 From: Ruslan Ermilov To: "David E. O'Brien" Message-ID: <20041018173516.GB89681@ip.net.ua> References: <200410181719.i9IHJa9l097436@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6sX45UoQRIJXqkqR" Content-Disposition: inline In-Reply-To: <200410181719.i9IHJa9l097436@repoman.freebsd.org> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new at ip.net.ua cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 17:35:33 -0000 --6sX45UoQRIJXqkqR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 18, 2004 at 05:19:36PM +0000, David E. O'Brien wrote: > obrien 2004-10-18 17:19:36 UTC >=20 > FreeBSD src repository >=20 > Modified files: > lib/libc/i386/net htonl.S ntohl.S=20 > Log: > Sync with sys/i386/include/endian.h: use the single instruction 'bswap'. > =20 > Revision Changes Path > 1.10 +4 -0 src/lib/libc/i386/net/htonl.S > 1.10 +4 -0 src/lib/libc/i386/net/ntohl.S =20 : ENTRY(__htonl) : movl 4(%esp),%eax : +#ifdef I386_CPU : xchgb %al,%ah : roll $16,%eax : xchgb %al,%ah : +#else : + bswap %eax : +#endif : ret Ahem, but this makes this code unsuitable for i386. I386_CPU is only defined if kernel config file has "cpu I386_CPU", and this has little relation to libc if at all. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --6sX45UoQRIJXqkqR Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBc/7UqRfpzJluFF4RAlb0AKCKBkmPwZ4YfmT8DjXGnPqFBghLJACeO+Q1 kf9ogMEfcUZVtZIln0505rw= =KpE8 -----END PGP SIGNATURE----- --6sX45UoQRIJXqkqR--