From owner-freebsd-current@FreeBSD.ORG Thu Jan 31 13:04:52 2008 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4B5D816A41A for ; Thu, 31 Jan 2008 13:04:52 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.175]) by mx1.freebsd.org (Postfix) with ESMTP id BB2D413C468 for ; Thu, 31 Jan 2008 13:04:51 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: by ug-out-1314.google.com with SMTP id y2so648579uge.37 for ; Thu, 31 Jan 2008 05:04:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; bh=gRMDMuIawhfWqtz0vTXotedgveQXoM6E5F95YEc7Nx4=; b=jTRpwGXiz270BD7DaRzR86rcDch5CJIIMPjJHkMoHBhrEzs1Z59mR0ve3/ncrVdh3/JirGzIVvXHap8RnYLJb3YyuU/lTGA7EsxDXHpN6Tept9D862ClhjgcB0QMWh6SpYjHu2A7C8SQwTYhcQKmOhyQuWB0xpaYcw1gQyppAi8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=pZq96vEO5nMAcRNvWLOpeM9PH9BmLEDmOMHJq+SO0YvcuA78lyWKcATUSCs5L6Gv/NXXsd5ET9lyRB7JNGBXb1Sy6z47NQSWlMwC+mbrkOQKdDs3NKchvDnOHgWohBGdI3USOeoTnv2rVLfoD/q/YjZv2UxbX5ZOhF3zhk2WQkw= Received: by 10.67.22.2 with SMTP id z2mr4080264ugi.1.1201784689723; Thu, 31 Jan 2008 05:04:49 -0800 (PST) Received: by 10.86.28.19 with HTTP; Thu, 31 Jan 2008 05:04:49 -0800 (PST) Message-ID: <3bbf2fe10801310504j486924bdm86e0436597a42b09@mail.gmail.com> Date: Thu, 31 Jan 2008 14:04:49 +0100 From: "Attilio Rao" Sender: asmrookie@gmail.com To: "Yar Tikhiy" In-Reply-To: <20080131130210.GA37090@comp.chem.msu.su> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <479BBDAA.6000008@FreeBSD.org> <479C0B5B.9030709@FreeBSD.org> <3bbf2fe10801270642m5ec609d8xb29add77ced36d8a@mail.gmail.com> <479FA3E8.10606@FreeBSD.org> <3bbf2fe10801291411v302dd33at54ebe538397e8fac@mail.gmail.com> <20080130130820.GA88429@comp.chem.msu.su> <3bbf2fe10801300707u3fd121c0k199605c2f0be6cbf@mail.gmail.com> <790a9fff0801301352xa91a69ci3f08488dfcfc982@mail.gmail.com> <3bbf2fe10801310243tddedfeckbc4c94be87f0a4ca@mail.gmail.com> <20080131130210.GA37090@comp.chem.msu.su> X-Google-Sender-Auth: fb49b7d299af9171 Cc: Kostik Belousov , Scot Hetzel , freebsd-current@freebsd.org, Doug Barton Subject: Re: panic: System call lstat returning with 1 locks held X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Jan 2008 13:04:52 -0000 2008/1/31, Yar Tikhiy : > On Thu, Jan 31, 2008 at 11:43:10AM +0100, Attilio Rao wrote: > > > > The assertion failing should not happen now. > > Could you please hand-add a check in _lockmgr_disown() > > (kern/kern_lock.c) in order to check for the panicstr before to call > > WITNESS? I cannot access to perforce now and produce a suitable diff, > > so you can just do this by hand: > > > > if (lkp->lk_lockholder == td) { > > if (panicstr != NULL) > > WITNESS_UNLOCK(&lkp->lk_object, LOP_EXCLUSIVE, file, line); > > td->td_locks--; > > } > > > Shouldn't the test for panicstr be inverse: `panicstr == NULL'? > I guess we shouldn't call WITNESS when panicing, should we? > Sorry if I got it wrong. Weee, you are right, sorry! Attilio -- Peace can only be achieved by understanding - A. Einstein