From owner-svn-src-all@freebsd.org Mon Dec 7 19:32:08 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1CFFE9B96A5 for ; Mon, 7 Dec 2015 19:32:08 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: from mail-wm0-x235.google.com (mail-wm0-x235.google.com [IPv6:2a00:1450:400c:c09::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B534518CD for ; Mon, 7 Dec 2015 19:32:07 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: by wmww144 with SMTP id w144so154211500wmw.1 for ; Mon, 07 Dec 2015 11:32:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=e7O1VZ0PdbKi96+JQ6rsm6JYCESaO/hsR1RJYjHkYSQ=; b=o8bTNCZ8oKvTxkiVyTEb5gfhEyoWPQZLuBatskQU+7nNyNfOUhDq+mHI3aCNzqjkTG zVlc2GpHHkjpqimA9or/z2VrC8r07h/xubvWudNyqMp4BkN/PY1vl/W2q9pI2YBOQ8vM cKHXwAAh6nHcxT1vLQ1UAGZxcvyp4CtqsUuvEBXeqP72aLXM99q6tclFa+ouQD2GqyM0 ti1l5VDv22dNZuD/ryiEnhdvdrjaqrSEFukTCafeaB3113GwDyodTj+U+NVu3Srvnzh1 XcLpDBPFdEwzpYSrGwX+GISPyiENqW2uHiAb2u+IHv0bVI3OQlSboxxQtSY4wXkSvw/y FtHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=e7O1VZ0PdbKi96+JQ6rsm6JYCESaO/hsR1RJYjHkYSQ=; b=e0sdVdzzvMh/9reUsofgJrH/vD1Ujf+dA99zWPi4hDi+Sh7rcHcbG9gmwC9RkkM79S VOQMUVDDjO8FQEltlTxiT0tzQbUYqgOg6+0htEp0BXpEgqopK6QDoZiOU0KjP2UnXGTX 3DlEK3iYNxZPgBAfjJ+BlnwcWgWfEDyMu2WkeLzE1E615mCfO5lhv3IP/+yWUTkFQNuk KTSGhCaLEjTQUgcd3HgaeTJNPZ4rR/4juTcH3mK5URge9kMlXMGftqv+yJujqs2q/Tnb X5obcZRDbQsjutTbo3DUoLGSYKMy5c6UrEFcW4UCDht8kPRB3+ahdT8h5QzMf1+AJLXO YVJw== X-Gm-Message-State: ALoCoQkFK7nkBRu06QK/GuMNtRu/irIZKpsz0ggrtKcHFuDIQCJO6DdObX3a5k5+yMXGh4/U0p9B MIME-Version: 1.0 X-Received: by 10.194.202.163 with SMTP id kj3mr33478330wjc.93.1449516725346; Mon, 07 Dec 2015 11:32:05 -0800 (PST) Received: by 10.194.85.167 with HTTP; Mon, 7 Dec 2015 11:32:05 -0800 (PST) In-Reply-To: <201512061746.tB6HkCWb072736@repo.freebsd.org> References: <201512061746.tB6HkCWb072736@repo.freebsd.org> Date: Mon, 7 Dec 2015 20:32:05 +0100 Message-ID: Subject: Re: svn commit: r291907 - head/sys/vm From: Oliver Pinter To: "Conrad E. Meyer" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Dec 2015 19:32:08 -0000 On 12/6/15, Conrad E. Meyer wrote: > Author: cem > Date: Sun Dec 6 17:46:12 2015 > New Revision: 291907 > URL: https://svnweb.freebsd.org/changeset/base/291907 > > Log: > vm_fault_hold: handle vm_page_rename failure > > On vm_page_rename failure, fix a missing object unlock and a double free > of > a page. > > First remove the old page, then rename into other page into first_object, > then free the old page. This avoids the problem on rename failure. This > is > a little ugly but seems to be the most straightforward solution. > > Tested with: > $ sysctl debug.fail_point.uma_zalloc_arg="1%return" > $ kyua test -k /usr/tests/sys/Kyuafile > > Submitted by: Ryan Libby > Reviewed by: kib > Seen by: alc > Sponsored by: EMC / Isilon Storage Division > Differential Revision: https://reviews.freebsd.org/D4326 > > Modified: > head/sys/vm/vm_fault.c > > Modified: head/sys/vm/vm_fault.c > Hi Conrad! You have any plan to MFC this commit?