From owner-cvs-all  Sun Feb 11  9:44:18 2001
Delivered-To: cvs-all@freebsd.org
Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42])
	by hub.freebsd.org (Postfix) with ESMTP
	id C96B737B491; Sun, 11 Feb 2001 09:44:11 -0800 (PST)
Received: (from ache@localhost)
	by nagual.pp.ru (8.11.2/8.11.2) id f1BHi8s94143;
	Sun, 11 Feb 2001 20:44:09 +0300 (MSK)
	(envelope-from ache)
Date: Sun, 11 Feb 2001 20:44:05 +0300
From: "Andrey A. Chernov" <ache@nagual.pp.ru>
To: Alexey Zelkin <phantom@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/lib/libc/locale lmessages.c
Message-ID: <20010211204400.A94085@nagual.pp.ru>
References: <200102111509.f1BF9Vg00411@freefall.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <200102111509.f1BF9Vg00411@freefall.freebsd.org>; from phantom@FreeBSD.org on Sun, Feb 11, 2001 at 07:09:31AM -0800
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

On Sun, Feb 11, 2001 at 07:09:31 -0800, Alexey Zelkin wrote:
> phantom     2001/02/11 07:09:31 PST
> 
>   Modified files:
>     lib/libc/locale      lmessages.c 
>   Log:
>   Don't use hardcoded struct size, use offsetof() instead (make size calculations
>   dynamic)

The same as for lnumeric/lmonetary is true here too, i.e.

if (!ret)

should be changed to

if (!ret && _messages_using_locale) 

TWO TIMES

Currecntly no bad effect, just waste few CPU cycles.

BTW, YESSTR/NOSTR should be fixed in nl_langinfo() too...

-- 
Andrey A. Chernov
http://ache.pp.ru/


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message