From owner-cvs-all@FreeBSD.ORG  Wed Nov 14 10:01:33 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 575BF16A41B;
	Wed, 14 Nov 2007 10:01:33 +0000 (UTC)
	(envelope-from kris@FreeBSD.org)
Received: from weak.local (pointyhat.freebsd.org [IPv6:2001:4f8:fff6::2b])
	by mx1.freebsd.org (Postfix) with ESMTP id 2DBF313C467;
	Wed, 14 Nov 2007 10:01:31 +0000 (UTC)
	(envelope-from kris@FreeBSD.org)
Message-ID: <473AC77C.40903@FreeBSD.org>
Date: Wed, 14 Nov 2007 11:01:32 +0100
From: Kris Kennaway <kris@FreeBSD.org>
User-Agent: Thunderbird 2.0.0.6 (Macintosh/20070728)
MIME-Version: 1.0
To: Julian Elischer <julian@FreeBSD.org>
References: <200711140543.lAE5ht3O020823@repoman.freebsd.org>
In-Reply-To: <200711140543.lAE5ht3O020823@repoman.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/i386/bios apm.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Nov 2007 10:01:33 -0000

Julian Elischer wrote:
> julian      2007-11-14 05:43:55 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/i386/bios        apm.c 
>   Log:
>   Apply the same sort of locking done in
>      sys/dev/acpica/acpi.c rev 1.196 a while ago:
>   
>   Grab Giant around calls to DEVICE_SUSPEND/RESUME in
>   acpi_SetSleepState().
>   If we are resuming non-MPSAFE drivers, they need Giant held for them.
>   This may fix some obscure suspend/resume problems.  It has fixed keyrate
>   setting problems that were triggered by cardbus (MPSAFE) changing the
>   ordering for syscons resume (non-MPSAFE).  Also, add some asserts that
>   Giant is held in our suspend/resume and shutdown methods.
>   
>   Submitted by: Marko Zec
>   
>   Revision  Changes    Path
>   1.149     +10 -0     src/sys/i386/bios/apm.c

Why are we adding new unconditional giant acquisitions to the tree? 
Devices indicate whether or not they are mpsafe, why can't this be made 
conditional?

Kris