From owner-freebsd-hackers  Tue Jul 27 20:41:19 1999
Delivered-To: freebsd-hackers@freebsd.org
Received: from rover.village.org (rover.village.org [204.144.255.49])
	by hub.freebsd.org (Postfix) with ESMTP
	id 7FDC415396; Tue, 27 Jul 1999 20:40:23 -0700 (PDT)
	(envelope-from imp@harmony.village.org)
Received: from harmony.village.org (harmony.village.org [10.0.0.6])
	by rover.village.org (8.9.3/8.9.3) with ESMTP id VAA68776;
	Tue, 27 Jul 1999 21:39:14 -0600 (MDT)
	(envelope-from imp@harmony.village.org)
Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.9.3/8.8.3) with ESMTP id VAA68413; Tue, 27 Jul 1999 21:40:34 -0600 (MDT)
Message-Id: <199907280340.VAA68413@harmony.village.org>
To: Sheldon Hearn <sheldonh@uunet.co.za>
Subject: Re: newsyslog owner.group -> owner:group 
Cc: Tim Vanderhoek <vanderh@ecf.utoronto.ca>, obrien@FreeBSD.ORG,
	hackers@FreeBSD.ORG
In-reply-to: Your message of "Tue, 27 Jul 1999 17:11:49 +0200."
		<19755.933088309@axl.noc.iafrica.com> 
References: <19755.933088309@axl.noc.iafrica.com>  
Date: Tue, 27 Jul 1999 21:40:34 -0600
From: Warner Losh <imp@village.org>
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

In message <19755.933088309@axl.noc.iafrica.com> Sheldon Hearn writes:
: +#ifdef SUPPORT_DOT
: +                /* Older configurations used '.' between user and group */
: +                if ((group = strchr(q, ':')) != NULL ||
: +                    (group = strchr(q, '.')) != NULL) {
: +#else
:                  if ((group = strchr(q, ':')) != NULL) {
: +#endif
:                      *group++ = '\0';

A better patch would check to see if the text to the right of the '.'
is a valid group...  However, the above will still parse

	fred.jones:fred.jones

in the most desirable way, so I suppose the validity checking is
overkill.

Warner


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message