From owner-freebsd-current Sat Jul 3 12:40:56 1999 Delivered-To: freebsd-current@freebsd.org Received: from argus.tfs.net (host1-19.birch.net [216.212.1.19]) by hub.freebsd.org (Postfix) with ESMTP id 26C221517A for ; Sat, 3 Jul 1999 12:40:45 -0700 (PDT) (envelope-from jbryant@argus.tfs.net) Received: (from jbryant@localhost) by argus.tfs.net (8.9.3/8.8.5) id OAA26973; Sat, 3 Jul 1999 14:40:26 -0500 (CDT) From: Jim Bryant Message-Id: <199907031940.OAA26973@argus.tfs.net> Subject: Re: Fixing other people's code (was: world broken in vinum (PATCH)) In-Reply-To: from Ben Rosengart at "Jul 3, 99 00:09:53 am" To: ben@skunk.org (Ben Rosengart) Date: Sat, 3 Jul 1999 14:40:25 -0500 (CDT) Cc: freebsd-current@freebsd.org Reply-To: jbryant@tfs.net X-Windows: R00LZ!@# MS-Winbl0wz DR00LZ!@# X-files: The truth is that the X-Files is fiction X-Republican: The best kind!!! X-Operating-System: FreeBSD 4.0-CURRENT #31: Thu Apr 8 10:40:17 CDT 1999 X-Mailer: ELM [version 2.4ME+ PL32 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In reply: > On Sat, 3 Jul 1999, Greg Lehey wrote: > > > I personally think that, in such a case, you'd be justified to commit > > it as a temporary measure. Due to the difference in time zones, this > > has hit people while I've been asleep. That doesn't mean the commit > > would stay, of course, but at least it would save people unnecessary > > pain. Note, of course, that I have now committed the correct file, > > which I had forgotten last night. > > > > What do you others think? > > Was the fix that wasn't yours correct? 'Cause I'd rather have code that > doesn't compile than code that compiles but is subtly wrong. untested code shouldn't be checked in to begin with. such are the basics of version control. mistakes happen in any project, but where i come from CVS/RCS/etc is for tested and working code. if i made such a mistake, i would be grateful for a temporary kludge submitted by someone, assuming they know that it is subject to a proper fix at any moment. jim -- All opinions expressed are mine, if you | "I will not be pushed, stamped, think otherwise, then go jump into turbid | briefed, debriefed, indexed, or radioactive waters and yell WAHOO !!! | numbered!" - #1, "The Prisoner" ------------------------------------------------------------------------------ Inet: jbryant@tfs.net AX.25: kc5vdj@wv0t.#neks.ks.usa.noam grid: EM28pw voice: KC5VDJ - 6 & 2 Meters AM/FM/SSB, 70cm FM. http://www.tfs.net/~jbryant ------------------------------------------------------------------------------ HF/6M/2M: IC-706-MkII, 2M: HTX-212, 2M: HTX-202, 70cm: HTX-404, Packet: KPC-3+ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message