From owner-freebsd-current@FreeBSD.ORG Wed Feb 13 03:39:37 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 4E706C82 for ; Wed, 13 Feb 2013 03:39:37 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) by mx1.freebsd.org (Postfix) with ESMTP id 10DFC855 for ; Wed, 13 Feb 2013 03:39:37 +0000 (UTC) Received: from troutmask.apl.washington.edu (localhost.apl.washington.edu [127.0.0.1]) by troutmask.apl.washington.edu (8.14.5/8.14.5) with ESMTP id r1D3dXJC089791; Tue, 12 Feb 2013 19:39:33 -0800 (PST) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.14.5/8.14.5/Submit) id r1D3dXIH089790; Tue, 12 Feb 2013 19:39:33 -0800 (PST) (envelope-from sgk) Date: Tue, 12 Feb 2013 19:39:33 -0800 From: Steve Kargl To: bf1783@gmail.com Subject: Re: 7+ days of dogfood Message-ID: <20130213033933.GA89757@troutmask.apl.washington.edu> References: <20130213014734.GA89321@troutmask.apl.washington.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: freebsd-current@freebsd.org, Anton Shterenlikht X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Feb 2013 03:39:37 -0000 On Wed, Feb 13, 2013 at 02:15:08AM +0000, b.f. wrote: > On 2/13/13, Steve Kargl wrote: > > On Wed, Feb 13, 2013 at 12:18:29AM +0000, b.f. wrote: > >> ># cat /etc/make.conf|grep FFLAGS > >> >FFLAGS = -O2 -pipe -march=native -mtune=native > >> > >> Please do _not_ assign flags unconditionally in make.conf. > > > > FFLAGS is for compiling Fortran. I'm one of the people who > > has spent years working/patching gfortran. I think I might > > have a better understanding of what options to use with > > gfortran than most people. > > > > I know you have, but you are giving advice that is liable to be abused > by those who are less experienced. The flags you are adding are not > the problem -- it's the way that you are adding them -- specifically, > the assignment in the first line of your snippet, if it's applied > unconditionally. You should either be appending all of them, or > assigning them conditionally, so that they are sure to be assigned > only once, or -- preferably -- using another makefile that can't be > re-read multiple times during a build (ports/Mk/bsd.port.mk > automatically includes several makefiles that can be used for this > purpose, if you are building a port). You have been lucky not to trip > over this: every couple of months for the last several years I have > had to debug errors reported by users that arise from this problem. It > is more common with CFLAGS and CXXFLAGS but it can happen with FFLAGS, > too. Try 'find /usr/ports -name Makefile -maxdepth 3 | xargs grep FFLAGS' Then go read about the options chosen by the various port maintainers. I specifically set FFLAGS to avoid the questionable options set in the ports. If -malign-double appears in a port, it should probably be marked as broken. If a port uses -fdefault-real-8, it should probably be marked as broken. If a port uses -ffast-math, it may have issues that are extremely difficult to debug. -- steve