From owner-freebsd-stable@FreeBSD.ORG Wed Feb 27 21:51:24 2008 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C4C3F106566B for ; Wed, 27 Feb 2008 21:51:24 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id 1B1E18FC18 for ; Wed, 27 Feb 2008 21:51:23 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8s) with ESMTP id 233622232-1834499 for multiple; Wed, 27 Feb 2008 16:49:22 -0500 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m1RLp8xZ036786; Wed, 27 Feb 2008 16:51:18 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: freebsd-stable@freebsd.org Date: Wed, 27 Feb 2008 16:41:42 -0500 User-Agent: KMail/1.9.7 References: <20080223120658.GA30178@asgard.home> <47C082E9.5000608@bsdforen.de> In-Reply-To: <47C082E9.5000608@bsdforen.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200802271641.42450.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Wed, 27 Feb 2008 16:51:19 -0500 (EST) X-Virus-Scanned: ClamAV 0.91.2/6014/Wed Feb 27 15:42:51 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: Dominic Fandrey , Oliver Herold , imp@freebsd.org Subject: Re: FreeBSD 7, Razer Copperhead mouse patch X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Feb 2008 21:51:24 -0000 On Saturday 23 February 2008 03:32:41 pm Dominic Fandrey wrote: > Oliver Herold wrote: > > Hi > > > > the Razer Copperhead mouse did work in FreeBSD 7 (current) for a long > > time, but after some period it stopped working. This patch from Uwe > > Grohnwaldt: > > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=usb/118670 > > > > fixes this wrong behaviour (it's detected as keyboard) and makes the > > mouse work in FreeBSD 7 again. Would be imho a nice addition for > > RELENG_7 (stable) or even Release. > > > > Cheers, Oliver > > Being a Razer fan and user I totally agree. Can you try this patch instead? Index: ums.c =================================================================== RCS file: /usr/cvs/src/sys/dev/usb/ums.c,v retrieving revision 1.97 diff -u -r1.97 ums.c --- ums.c 26 Dec 2007 14:31:16 -0000 1.97 +++ ums.c 27 Feb 2008 21:40:48 -0000 @@ -198,7 +198,10 @@ if (err) return (UMATCH_NONE); - if (id->bInterfaceClass == UICLASS_HID && + if (hid_is_collection(desc, size, + HID_USAGE2(HUP_GENERIC_DESKTOP, HUG_MOUSE))) + ret = UMATCH_IFACECLASS; + else if (id->bInterfaceClass == UICLASS_HID && id->bInterfaceSubClass == UISUBCLASS_BOOT && id->bInterfaceProtocol == UIPROTO_MOUSE) ret = UMATCH_IFACECLASS; -- John Baldwin