From owner-cvs-src@FreeBSD.ORG Sun Mar 21 06:45:30 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 970C616A4CF; Sun, 21 Mar 2004 06:45:30 -0800 (PST) Received: from darkness.comp.waw.pl (unknown [195.117.238.236]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3FC1743D31; Sun, 21 Mar 2004 06:45:30 -0800 (PST) (envelope-from pjd@darkness.comp.waw.pl) Received: by darkness.comp.waw.pl (Postfix, from userid 1009) id 49388AC976; Sun, 21 Mar 2004 15:45:28 +0100 (CET) Date: Sun, 21 Mar 2004 15:45:28 +0100 From: Pawel Jakub Dawidek To: "Matthew N. Dodd" Message-ID: <20040321144528.GF8930@darkness.comp.waw.pl> References: <200403210634.i2L6YYj4087193@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="1ugEqy3masBx2OgH" Content-Disposition: inline In-Reply-To: <200403210634.i2L6YYj4087193@repoman.freebsd.org> User-Agent: Mutt/1.4.2i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 5.2.1-RC2 i386 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_arcsubr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Mar 2004 14:45:30 -0000 --1ugEqy3masBx2OgH Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 20, 2004 at 10:34:34PM -0800, Matthew N. Dodd wrote: +> mdodd 2004/03/20 22:34:34 PST +>=20 +> FreeBSD src repository +>=20 +> Modified files: +> sys/net if_arcsubr.c=20 +> Log: +> Handle AF_ARP. [...] +> + switch(ntohs(ah->ar_op)) { +> + case ARPOP_REVREQUEST: +> + case ARPOP_REVREPLY: +> + type =3D htons(ARCTYPE_REVARP); +> + break; +> + case ARPOP_REQUEST: +> + case ARPOP_REPLY: +> + default: +> + type =3D htons(ARCTYPE_ARP); +> + break; +> + } [...] Tinderbox is reporting failures, probably because you planned to use 'atype' here, instead of 'type', but I don't want to fix it, because I don't understand this: 'atype' is a u_int8_t, so I think htons() will transform in to '0' on some archs (e.g. i386) and I don't think it was your intention. --=20 Pawel Jakub Dawidek http://www.FreeBSD.org pjd@FreeBSD.org http://garage.freebsd.pl FreeBSD committer Am I Evil? Yes, I Am! --1ugEqy3masBx2OgH Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAXaqIForvXbEpPzQRAhysAKC3I0Gpk2fd8K9bF4guEBwPFS3r7wCeMZlO 6n9JHsa5dTJuVi7aJphAV90= =stXI -----END PGP SIGNATURE----- --1ugEqy3masBx2OgH--