From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Jun 28 12:45:03 2014 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1EFD4A2D for ; Sat, 28 Jun 2014 12:45:03 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E08922487 for ; Sat, 28 Jun 2014 12:45:02 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.8/8.14.8) with ESMTP id s5SCj2lM099620 for ; Sat, 28 Jun 2014 13:45:02 +0100 (BST) (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 191459] New: x11-drivers/xf86-input/keyboard - prevent segfaults for vt(4) users Date: Sat, 28 Jun 2014 12:45:03 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports Tree X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: clbuisson@orange.fr X-Bugzilla-Status: Needs Triage X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Jun 2014 12:45:03 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191459 Bug ID: 191459 Summary: x11-drivers/xf86-input/keyboard - prevent segfaults for vt(4) users Product: Ports Tree Version: Latest Hardware: Any OS: Any Status: Needs Triage Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: freebsd-ports-bugs@FreeBSD.org Reporter: clbuisson@orange.fr In src/bsd_KbdMap.c, the function KbdGetMapping is called to setup an appropriate keyboard map. At line 1260 the function calls ioctl(pInfo->fd, GIO_KEYMAP, &keymap) to get the current OS keyboard mapping, then loops accessing the table eascii_to_x|] to map keyboard delivered chars to X KeySyms. 1. this table is built from the cp437 definition, which is only a special case, not taking into account the many character codes being in real use. 2. the code assumes that the character values delivered by the FreeBSD keyboard driver are only 1 byte wide, which may not be the case using syscons with option TEKEN_UTF8 or using newcons/vt(4). A consequence is that out of bounds accesses are done to the eascii_to_x[] table returning at best meaningless results, or at worst (every time on my amd64 systems) leadind to segmentation faults. As this mapping operation seems to be rather useless, I use a workaround which is to #ifdef this part of the code, using the attached patch. I hope that someone more knowledgeable than me can validate/refine this hack. -- You are receiving this mail because: You are the assignee for the bug.