From owner-svn-src-all@FreeBSD.ORG  Sat Jan  7 14:15:32 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5AE1D106564A
	for <svn-src-all@freebsd.org>; Sat,  7 Jan 2012 14:15:32 +0000 (UTC)
	(envelope-from ronald-freebsd8@klop.yi.org)
Received: from fep28.mx.upcmail.net (fep28.mx.upcmail.net [62.179.121.48])
	by mx1.freebsd.org (Postfix) with ESMTP id 9F5338FC0A
	for <svn-src-all@freebsd.org>; Sat,  7 Jan 2012 14:15:31 +0000 (UTC)
Received: from edge03.upcmail.net ([192.168.13.238]) by viefep14-int.chello.at
	(InterMail vM.8.01.05.04 201-2260-151-105-20111014) with ESMTP
	id <20120107135836.CKHW12772.viefep14-int.chello.at@edge03.upcmail.net>;
	Sat, 7 Jan 2012 14:58:36 +0100
Received: from pinky ([77.251.58.236]) by edge03.upcmail.net with edge
	id Jdya1i00h55oZSd03dya1t; Sat, 07 Jan 2012 14:58:36 +0100
X-SourceIP: 77.251.58.236
Content-Type: text/plain; charset=us-ascii; format=flowed; delsp=yes
To: svn-src-all@freebsd.org, "Pawel Jakub Dawidek" <pjd@freebsd.org>
References: <201201040704.q0474iIe065299@svn.freebsd.org>
Date: Sat, 07 Jan 2012 14:58:34 +0100
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
From: "Ronald Klop" <ronald-freebsd8@klop.yi.org>
Message-ID: <op.v7pvrwk38527sy@pinky>
In-Reply-To: <201201040704.q0474iIe065299@svn.freebsd.org>
User-Agent: Opera Mail/11.60 (Win32)
Cc: 
Subject: Re: svn commit: r229466 - head/usr.sbin/mptable
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 07 Jan 2012 14:15:32 -0000

I don't know much about this code, but is chmod 0666 really wat is wanted  
here (and in the commits following this one)? It makes the file world  
writable. And that smells funny. :-)

Ronald.

On Wed, 04 Jan 2012 08:04:44 +0100, Pawel Jakub Dawidek <pjd@freebsd.org>  
wrote:

> Author: pjd
> Date: Wed Jan  4 07:04:43 2012
> New Revision: 229466
> URL: http://svn.freebsd.org/changeset/base/229466
>
> Log:
>   Add an missing argument to open(2). If O_CREAT flag is specified,
>   file permission has to be specified as well.
>
> Modified:
>   head/usr.sbin/mptable/mptable.c
>
> Modified: head/usr.sbin/mptable/mptable.c
> ==============================================================================
> --- head/usr.sbin/mptable/mptable.c	Wed Jan  4 07:01:23 2012	(r229465)
> +++ head/usr.sbin/mptable/mptable.c	Wed Jan  4 07:04:43 2012	(r229466)
> @@ -828,7 +828,7 @@ MPConfigTableHeader( u_int32_t pap )
>      int		ofd;
>      u_char	dumpbuf[ 4096 ];
> -    ofd = open( "/tmp/mpdump", O_CREAT | O_RDWR );
> +    ofd = open( "/tmp/mpdump", O_CREAT | O_RDWR, 0666 );
>      seekEntry( paddr );
>      readEntry( dumpbuf, 1024 );
>      write( ofd, dumpbuf, 1024 );
> _______________________________________________
> svn-src-all@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/svn-src-all
> To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"