From owner-cvs-src@FreeBSD.ORG Thu Oct 25 19:06:13 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AE7B116A41A; Thu, 25 Oct 2007 19:06:13 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.geekcn.org (tarsier.geekcn.org [210.51.165.229]) by mx1.freebsd.org (Postfix) with ESMTP id 1866C13C49D; Thu, 25 Oct 2007 19:06:13 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from localhost (tarsier.geekcn.org [210.51.165.229]) by tarsier.geekcn.org (Postfix) with ESMTP id 1A22EEC2F00; Fri, 26 Oct 2007 03:06:11 +0800 (CST) X-Virus-Scanned: amavisd-new at geekcn.org Received: from tarsier.geekcn.org ([210.51.165.229]) by localhost (mail.geekcn.org [210.51.165.229]) (amavisd-new, port 10024) with ESMTP id 3ZE-91WSEBBb; Fri, 26 Oct 2007 03:05:57 +0800 (CST) Received: from LI-Xins-MacBook.local (71.5.7.139.ptr.us.xo.net [71.5.7.139]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tarsier.geekcn.org (Postfix) with ESMTP id B2B08EB27B1; Fri, 26 Oct 2007 03:05:54 +0800 (CST) DomainKey-Signature: a=rsa-sha1; s=default; d=delphij.net; c=nofws; q=dns; h=message-id:date:from:reply-to:organization:user-agent: mime-version:to:cc:subject:references:in-reply-to: x-enigmail-version:openpgp:content-type; b=wyYGlGLw7Lz2te6RUfsTeOhEZBsDL/ZvrfFcgbIul2xVdlRBeISPrcxsL8fMvPlg3 XRmxvGXgiC4JhCBoBdoqw== Message-ID: <4720E904.2090704@delphij.net> Date: Thu, 25 Oct 2007 12:05:40 -0700 From: LI Xin Organization: The FreeBSD Project User-Agent: Thunderbird 2.0.0.6 (Macintosh/20070728) MIME-Version: 1.0 To: Scott Long References: <200710150951.l9F9pUm7026506@repoman.freebsd.org> <4720B30F.4040903@samsco.org> <20071025151707.GA11398@nagual.pp.ru> <4720E0AF.1010004@samsco.org> In-Reply-To: <4720E0AF.1010004@samsco.org> X-Enigmail-Version: 0.95.4 OpenPGP: url=http://www.delphij.net/delphij.asc Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigD35512CB7A3D5D49436D5B78" Cc: Andrey Chernov , src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-src@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libc/locale utf8.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: d@delphij.net List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Oct 2007 19:06:13 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigD35512CB7A3D5D49436D5B78 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Scott Long wrote: > Andrey Chernov wrote: >> On Thu, Oct 25, 2007 at 09:15:27AM -0600, Scott Long wrote: >>> Andrey A. Chernov wrote: >>>> ache 2007-10-15 09:51:30 UTC >>>> FreeBSD src repository >>>> Modified files: >>>> lib/libc/locale utf8.c Log: >>>> Add comment explaining __mb_sb_limit trick here. >>>> Revision Changes Path >>>> 1.16 +5 -0 src/lib/libc/locale/utf8.c >>> When is the ABI damage from this going to be fixed? >> >> There is no ABI damage in -current. >> >=20 > Exposing the __mb_sb_limit symbol has instantly created a need > to have a compat7x package, and is causing many users problems > during upgrades and normal operations. It may not be a problem > for you, Andre, but it's a problem for everyone else. Please > respect this and fix it. Well, I think the problem is not exposing a new symbol by itself, but __mb_sb_limit is being used in _ctype.h, in a form of __inline functions. Therefore, the change will break new binaries running on older systems. Personally I think this is acceptable, but maybe we could have a better way to avoid this, because the binaries are no longer backward compatible (i.e. you may have trouble running a program compiled for 6.3-RELEASE on 6.2-RELEASE, if it uses locale bits). As a workaround as discussed with rafan@ we have installed a workaround for now, which installs libc.so.6 before all other shared objects, which will make the problem invisible. Cheers, --=20 Xin LI http://www.delphij.net/ FreeBSD - The Power to Serve! --------------enigD35512CB7A3D5D49436D5B78 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHIOkEOfuToMruuMARCk/bAKCNIuK6sJ+vECSNE26vov1YwKjFyQCfdRmW mbXH6FxoRmVaG1imJCFakiA= =MCsb -----END PGP SIGNATURE----- --------------enigD35512CB7A3D5D49436D5B78--