From owner-freebsd-ports-bugs@FreeBSD.ORG  Wed Jul  2 03:36:48 2014
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 8EE74E11
 for <freebsd-ports-bugs@FreeBSD.org>; Wed,  2 Jul 2014 03:36:48 +0000 (UTC)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 5D19B2F63
 for <freebsd-ports-bugs@FreeBSD.org>; Wed,  2 Jul 2014 03:36:48 +0000 (UTC)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.8/8.14.8) with ESMTP id s623amZG013871
 for <freebsd-ports-bugs@FreeBSD.org>; Wed, 2 Jul 2014 04:36:48 +0100 (BST)
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-ports-bugs@FreeBSD.org
Subject: [Bug 191547] New: Flag PKG_ADD_USE_UPGRADE_SCRIPTS have never be set
 in pkgng
Date: Wed, 02 Jul 2014 03:36:48 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Ports Tree
X-Bugzilla-Component: Individual Port(s)
X-Bugzilla-Version: Latest
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Many People
X-Bugzilla-Who: tuupic@gmail.com
X-Bugzilla-Status: Needs Triage
X-Bugzilla-Priority: Normal
X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-191547-13@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Jul 2014 03:36:48 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191547

            Bug ID: 191547
           Summary: Flag PKG_ADD_USE_UPGRADE_SCRIPTS have never be set in
                    pkgng
           Product: Ports Tree
           Version: Latest
          Hardware: Any
                OS: Any
            Status: Needs Triage
          Severity: Affects Many People
          Priority: Normal
         Component: Individual Port(s)
          Assignee: freebsd-ports-bugs@FreeBSD.org
          Reporter: tuupic@gmail.com

This bug about pkgng

In pkgng documentation written that exists scripts pre-upgrade, post-upgrade
and upgrade (https://wiki.freebsd.org/pkgng#Scripts)
But those scripts can not be run.
Because they enables via flag PKG_ADD_USE_UPGRADE_SCRIPTS

libpkg/pkg_add.c:
============================
        if ((flags & PKG_ADD_NOSCRIPT) == 0) {
                if ((flags & PKG_ADD_USE_UPGRADE_SCRIPTS) ==
PKG_ADD_USE_UPGRADE_SCRIPTS)
                        pkg_script_run(pkg, PKG_SCRIPT_POST_UPGRADE);
                else
                        pkg_script_run(pkg, PKG_SCRIPT_POST_INSTALL);
        }
============================

But this flag never be set

============================
[root@srv5 /usr/ports/ports-mgmt/pkg]# grep -R PKG_ADD_USE_UPGRADE_SCRIPTS
work/
work/pkg-1.2.7/libpkg/pkg.h.in:#define PKG_ADD_USE_UPGRADE_SCRIPTS      (1U <<
1)
work/pkg-1.2.7/libpkg/pkg_add.c:        if ((flags & (PKG_ADD_NOSCRIPT |
PKG_ADD_USE_UPGRADE_SCRIPTS)) == 0)
work/pkg-1.2.7/libpkg/pkg_add.c:                if ((flags &
PKG_ADD_USE_UPGRADE_SCRIPTS) == PKG_ADD_USE_UPGRADE_SCRIPTS)
[root@srv5 /usr/ports/ports-mgmt/pkg]#
============================


So scripts pre-upgrade, post-upgrade, upgrade are broken.

-- 
You are receiving this mail because:
You are the assignee for the bug.