From owner-freebsd-current Mon Feb 10 20:39: 2 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BF3E937B401; Mon, 10 Feb 2003 20:39:00 -0800 (PST) Received: from out002.verizon.net (out002pub.verizon.net [206.46.170.141]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6885143F3F; Mon, 10 Feb 2003 20:38:59 -0800 (PST) (envelope-from mtm@identd.net) Received: from kokeb.ambesa.net ([138.88.50.112]) by out002.verizon.net (InterMail vM.5.01.05.20 201-253-122-126-120-20021101) with ESMTP id <20030211043858.ECXO7656.out002.verizon.net@kokeb.ambesa.net>; Mon, 10 Feb 2003 22:38:58 -0600 Date: Mon, 10 Feb 2003 23:38:57 -0500 From: Mike Makonnen To: Tim Robbins Cc: phk@phk.freebsd.dk, current@freebsd.org Subject: Re: MSDOSFS wastes 256k when nothing is mounted! In-Reply-To: <20030210133148.A17199@dilbert.robbins.dropbear.id.au> References: <31456.1044819599@critter.freebsd.dk> <20030209230848.VZI7113.pop015.verizon.net@kokeb.ambesa.net> <20030210133148.A17199@dilbert.robbins.dropbear.id.au> X-Mailer: Sylpheed version 0.8.10 (GTK+ 1.2.10; i386-portbld-freebsd5.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Authentication-Info: Submitted using SMTP AUTH at out002.verizon.net from [138.88.50.112] at Mon, 10 Feb 2003 22:38:57 -0600 Message-Id: <20030211043858.ECXO7656.out002.verizon.net@kokeb.ambesa.net> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, 10 Feb 2003 13:31:48 +1100 Tim Robbins wrote: > It might be better to initialise the table the first time an > msdosfs filesystem is mounted. > This implies that the existence of the hash table be revealed outside the module. Is this a layering violation? None of the _vfsops functions (except for init/uninit) can currently see the hash table, and of the ones that deal with denodes, none of them uses it directly. We can keep knowledge of the hashtable"in module" if we do the initialization in deget(), before the vnode lock. This seems like a better(if a little hackish) option to me, but this is the first time I've dealt with the filesystem so please let me know if I have the wrong idea. Cheers. -- Mike Makonnen | GPG-KEY: http://www.identd.net/~mtm/mtm.asc mtm@identd.net | Fingerprint: D228 1A6F C64E 120A A1C9 A3AA DAE1 E2AF DBCC 68B9 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message