From owner-freebsd-current Sat Jul 3 19: 8:40 1999 Delivered-To: freebsd-current@freebsd.org Received: from allegro.lemis.com (allegro.lemis.com [192.109.197.134]) by hub.freebsd.org (Postfix) with ESMTP id B124014F51 for ; Sat, 3 Jul 1999 19:08:30 -0700 (PDT) (envelope-from grog@freebie.lemis.com) Received: from freebie.lemis.com (freebie.lemis.com [192.109.197.137]) by allegro.lemis.com (8.9.1/8.9.0) with ESMTP id LAA18932; Sun, 4 Jul 1999 11:38:28 +0930 (CST) Received: (from grog@localhost) by freebie.lemis.com (8.9.3/8.9.0) id LAA07064; Sun, 4 Jul 1999 11:38:24 +0930 (CST) Date: Sun, 4 Jul 1999 11:38:22 +0930 From: Greg Lehey To: jbryant@tfs.net Cc: Ben Rosengart , freebsd-current@FreeBSD.ORG Subject: Re: Fixing other people's code (was: world broken in vinum (PATCH)) Message-ID: <19990704113820.K709@freebie.lemis.com> References: <199907031940.OAA26973@argus.tfs.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.95.4i In-Reply-To: <199907031940.OAA26973@argus.tfs.net>; from Jim Bryant on Sat, Jul 03, 1999 at 02:40:25PM -0500 WWW-Home-Page: http://www.lemis.com/~grog X-PGP-Fingerprint: 6B 7B C3 8C 61 CD 54 AF 13 24 52 F8 6D A4 95 EF Organization: LEMIS, PO Box 460, Echunga SA 5153, Australia Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-41-739-7062 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Saturday, 3 July 1999 at 14:40:25 -0500, Jim Bryant wrote: > In reply: >> On Sat, 3 Jul 1999, Greg Lehey wrote: >> >>> I personally think that, in such a case, you'd be justified to commit >>> it as a temporary measure. Due to the difference in time zones, this >>> has hit people while I've been asleep. That doesn't mean the commit >>> would stay, of course, but at least it would save people unnecessary >>> pain. Note, of course, that I have now committed the correct file, >>> which I had forgotten last night. >>> >>> What do you others think? >> >> Was the fix that wasn't yours correct? 'Cause I'd rather have code that >> doesn't compile than code that compiles but is subtly wrong. > > untested code shouldn't be checked in to begin with. such are the > basics of version control. mistakes happen in any project, but where > i come from CVS/RCS/etc is for tested and working code. Note that the case we're talking about here wasn't an issue of untested code. The code had been tested, and it works. The problem was that I had forgotten to commit one file. Normally, after committing a set of changes, I cvsup and do a "make world". That takes time, of course, and it doesn't stop others from tripping over the same problem. > if i made such a mistake, i would be grateful for a temporary kludge > submitted by someone, assuming they know that it is subject to a > proper fix at any moment. Agreed. Greg -- See complete headers for address, home page and phone numbers finger grog@lemis.com for PGP public key To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message