From owner-cvs-all Fri Jul 23 19:53: 9 1999 Delivered-To: cvs-all@freebsd.org Received: from awfulhak.org (dynamic-29.max1-du-ws.dialnetwork.pavilion.co.uk [212.74.8.29]) by hub.freebsd.org (Postfix) with ESMTP id 11D1B1562F; Fri, 23 Jul 1999 19:53:04 -0700 (PDT) (envelope-from brian@Awfulhak.org) Received: from keep.lan.Awfulhak.org (root@keep.lan.Awfulhak.org [172.16.0.8]) by awfulhak.org (8.9.3/8.9.3) with ESMTP id DAA08136; Sat, 24 Jul 1999 03:50:46 +0100 (BST) (envelope-from brian@lan.awfulhak.org) Received: from keep.lan.Awfulhak.org (brian@localhost [127.0.0.1]) by keep.lan.Awfulhak.org (8.9.3/8.9.3) with ESMTP id DAA03865; Sat, 24 Jul 1999 03:51:02 +0100 (BST) (envelope-from brian@keep.lan.Awfulhak.org) Message-Id: <199907240251.DAA03865@keep.lan.Awfulhak.org> X-Mailer: exmh version 2.0.2 2/24/98 To: John-Mark Gurney Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_tun.c In-reply-to: Your message of "Fri, 23 Jul 1999 13:08:29 PDT." <199907232008.NAA91250@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sat, 24 Jul 1999 03:51:00 +0100 From: Brian Somers Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk > jmg 1999/07/23 13:08:28 PDT > > Modified files: > sys/net if_tun.c > Log: > fix a problem w/ zero byte writes to the tunnel device. It would bypass > the loop and not set an error, so we would then try to access an invalid > mbuf... > > PR: 12780 > Submitted by: bright@rush.net aka zb^3 > > a new record in length a pr was open... only about a half hour... > > Revision Changes Path > 1.61 +1 -1 src/sys/net/if_tun.c I don't think I agree that writing 0 bytes should result in EIO, perhaps EINVAL would be more apt ? -- Brian Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message