From owner-cvs-src@FreeBSD.ORG Fri Feb 16 09:17:56 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 88CBD16A402; Fri, 16 Feb 2007 09:17:56 +0000 (UTC) (envelope-from p.dawidek@wheel.pl) Received: from swift.wheel.pl (zoidberg.sec-force.net [80.55.205.180]) by mx1.freebsd.org (Postfix) with ESMTP id 24D9C13C428; Fri, 16 Feb 2007 09:17:56 +0000 (UTC) (envelope-from p.dawidek@wheel.pl) Received: by swift.wheel.pl (Postfix, from userid 58) id 2DBDB8A3A8; Fri, 16 Feb 2007 09:33:26 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on swift.wheel.pl X-Spam-Level: X-Spam-Status: No, score=-2.2 required=5.0 tests=AWL, BAYES_00, SUBJ_HAS_SPACES autolearn=no version=3.1.1 Received: from localhost (154.81.datacomsa.pl [195.34.81.154]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by swift.wheel.pl (Postfix) with ESMTP id D20D98A149; Fri, 16 Feb 2007 09:33:21 +0100 (CET) Date: Fri, 16 Feb 2007 09:58:10 +0100 From: Pawel Jakub Dawidek To: Robert Watson Message-ID: <20070216085810.GB55867@garage.freebsd.pl> References: <200702152208.l1FM8aY7002188@repoman.freebsd.org> <20070216073206.C83539@fledge.watson.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="7ZAtKRhVyVSsbBD2" Content-Disposition: inline In-Reply-To: <20070216073206.C83539@fledge.watson.org> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng/devel-r804 (FreeBSD) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/fs/hpfs hpfs_vfsops.c hpfs_vnops.c src/sys/fs/msdosfs msdosfs_vfsops.c msdosfs_vnops.c src/sys/fs/ntfs ntfs_vfsops.c ntfs_vnops.c src/sys/fs/nullfs null_vfsops.c null_vnops.c src/sys/fs/udf udf.h udf_vfsops.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Feb 2007 09:17:56 -0000 --7ZAtKRhVyVSsbBD2 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 16, 2007 at 07:33:12AM +0000, Robert Watson wrote: >=20 > On Thu, 15 Feb 2007, Pawel Jakub Dawidek wrote: >=20 > > Move vnode-to-file-handle translation from vfs_vptofh to vop_vptofh met= hod. > > This way we may support multiple structures in v_data vnode field within > > one file system without using black magic. > > > > Vnode-to-file-handle should be VOP in the first place, but was made VFS > > operation to keep interface as compatible as possible with SUN's VFS. > > BTW. Now Solaris also implements vnode-to-file-handle as VOP operation. > > > > VFS_VPTOFH() was left for API backward compatibility, but is marked for > > removal before 8.0-RELEASE. > > > > Approved by: mckusick > > Discussed with: many (on IRC) > > Tested with: ufs, msdosfs, cd9660, nullfs and zfs >=20 > Do you think API backward compatibility is actually required in 7.x? It = looks like you've updated all the file systems, in which case the temptatio= n would be to drop it as=20 > we already have other VFS changes in 7.x from 6.x. Those changes break API or only ABI? My change break ABI backward compatibility, but I thought it will be good to leave API compatibility so 3rd party file systems (eg. from ports) have time to catch-up. If this is not necessary, I'll remove it right away. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --7ZAtKRhVyVSsbBD2 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFF1XIiForvXbEpPzQRAhaiAKDj40k2T9j+W53HtBIdxJvVFOljRQCgvfWF i/gmWuS/+kvi/6hQBtJKXRM= =MFvo -----END PGP SIGNATURE----- --7ZAtKRhVyVSsbBD2--