From owner-svn-src-all@FreeBSD.ORG Sat Jan 7 19:57:08 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 398F11065673 for ; Sat, 7 Jan 2012 19:57:08 +0000 (UTC) (envelope-from pawel@dawidek.net) Received: from mail.dawidek.net (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id E25778FC15 for ; Sat, 7 Jan 2012 19:57:07 +0000 (UTC) Received: from localhost (89-73-195-149.dynamic.chello.pl [89.73.195.149]) by mail.dawidek.net (Postfix) with ESMTPSA id 1506D2CD; Sat, 7 Jan 2012 20:57:04 +0100 (CET) Date: Sat, 7 Jan 2012 20:55:58 +0100 From: Pawel Jakub Dawidek To: Ronald Klop Message-ID: <20120107195557.GA1674@garage.freebsd.pl> References: <201201040704.q0474iIe065299@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="0OAP2g/MAC+5xKAE" Content-Disposition: inline In-Reply-To: X-OS: FreeBSD 9.0-CURRENT amd64 User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-all@freebsd.org Subject: Re: svn commit: r229466 - head/usr.sbin/mptable X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Jan 2012 19:57:08 -0000 --0OAP2g/MAC+5xKAE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jan 07, 2012 at 02:58:34PM +0100, Ronald Klop wrote: > I don't know much about this code, but is chmod 0666 really wat is wanted= =20 > here (and in the commits following this one)? It makes the file world =20 > writable. And that smells funny. :-) File permission during creation is always ANDed with process' umask. Most of the time umask is 022, so result file permission will be 0644. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com --0OAP2g/MAC+5xKAE Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAk8Io00ACgkQForvXbEpPzSnJwCcDGhtjtubcpglpy13IdSYLmf7 xvwAoMf7CdbufeJHBhC07YcZOlddeNWR =yBTt -----END PGP SIGNATURE----- --0OAP2g/MAC+5xKAE--