From owner-freebsd-current Sun May 7 14:44:41 2000 Delivered-To: freebsd-current@freebsd.org Received: from localhost (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id CFEEA37C1D3; Sun, 7 May 2000 14:44:28 -0700 (PDT) (envelope-from green@FreeBSD.org) Date: Sun, 7 May 2000 17:44:27 -0400 (EDT) From: Brian Fundakowski Feldman X-Sender: green@green.dyndns.org To: Mike Smith Cc: "Andrey A. Chernov" , FreeBSD Committers , FreeBSD current users Subject: Re: ed driver broken in today's -CURRENT? In-Reply-To: <200005072144.OAA11888@mass.cdrom.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sun, 7 May 2000, Mike Smith wrote: > > Since there's a sysctl you can use to turn the former off, perhaps it > would have been smart to take a few seconds to narrow it down? Those changes wouldn't have affected ICMP, but we tried that anyway. The problem was that the code changed the expression ~sum & 0xffff to sum == 0xffff ? sum : ~sum & 0xffff. I had just found and fixed this locally when I noticed Paul Saab committed the same functional fix. Well, it's nice to know that we can get multiple people finding the problem as soon as the symptoms of the breakage are known :) > -- > \\ Give a man a fish, and you feed him for a day. \\ Mike Smith > \\ Tell him he should learn how to fish himself, \\ msmith@freebsd.org > \\ and he'll hate you for a lifetime. \\ msmith@cdrom.com -- Brian Fundakowski Feldman \ FreeBSD: The Power to Serve! / green@FreeBSD.org `------------------------------' To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message