From owner-cvs-src@FreeBSD.ORG  Thu May 26 11:59:06 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id CAA3716A428;
	Thu, 26 May 2005 11:59:06 +0000 (GMT) (envelope-from mux@freebsd.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A55AE43D48;
	Thu, 26 May 2005 11:59:06 +0000 (GMT) (envelope-from mux@freebsd.org)
Received: by elvis.mu.org (Postfix, from userid 1920)
	id 7099C5C9E6; Thu, 26 May 2005 04:59:06 -0700 (PDT)
Date: Thu, 26 May 2005 13:59:06 +0200
From: Maxime Henrion <mux@FreeBSD.org>
To: Ollivier Robert <roberto@FreeBSD.org>
Message-ID: <20050526115906.GD25142@elvis.mu.org>
References: <200505261057.j4QAv4oU071149@repoman.freebsd.org>
	<20050526110238.GC25142@elvis.mu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050526110238.GC25142@elvis.mu.org>
User-Agent: Mutt/1.4.2.1i
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/usr.sbin/chkgrp chkgrp.8 chkgrp.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 26 May 2005 11:59:07 -0000

Maxime Henrion wrote:
> Ollivier Robert wrote:
> > roberto     2005-05-26 10:57:04 UTC
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     usr.sbin/chkgrp      chkgrp.8 chkgrp.c 
> >   Log:
> >   - Add further functionality to check for invalid characters
> >   - Remove keyword 'continue' for more indepth error reporting
> >     on each line
> >   - WARNS 6 Clean
> 
> As I said to Liam some time ago, the use of strcspn() in this file is
> bogus.  It's not Liam's fault, he only moved this code, and didn't
> introduce it.  However, it would be nice to fix this since calling
> strcspn(foo, " \t") has no chances of working as expected :-).

Actually, I got confused...  This is perfectly correct.

Maxime