From owner-cvs-ports@FreeBSD.ORG Sun Jun 6 10:07:23 2004 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2914816A4CE; Sun, 6 Jun 2004 10:07:23 -0700 (PDT) Received: from creme-brulee.marcuscom.com (rrcs-midsouth-24-172-16-118.biz.rr.com [24.172.16.118]) by mx1.FreeBSD.org (Postfix) with ESMTP id A8D2443D49; Sun, 6 Jun 2004 10:07:22 -0700 (PDT) (envelope-from marcus@FreeBSD.org) Received: from [192.168.1.4] (shumai.marcuscom.com [192.168.1.4]) i56H6Ong079415; Sun, 6 Jun 2004 13:06:24 -0400 (EDT) (envelope-from marcus@FreeBSD.org) From: Joe Marcus Clarke To: Oliver Eikemeier In-Reply-To: <40C2CE39.5030402@fillmore-labs.com> References: <200406060106.i5616XNX076254@repoman.freebsd.org> <40C2CE39.5030402@fillmore-labs.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-qeL1q4OifjKwIdAGI0t3" Organization: FreeBSD, Inc. Message-Id: <1086541625.34425.1.camel@shumai.marcuscom.com> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 Date: Sun, 06 Jun 2004 13:07:05 -0400 X-Spam-Status: No, hits=-4.9 required=5.0 tests=BAYES_00 autolearn=ham version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on creme-brulee.marcuscom.com cc: cvs-ports@FreeBSD.org cc: cvs-all@FreeBSD.org cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/devel/portlint Makefile ports/devel/portlint/src portlint.pl X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2004 17:07:23 -0000 --=-qeL1q4OifjKwIdAGI0t3 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Sun, 2004-06-06 at 03:56, Oliver Eikemeier wrote: > Joe Marcus Clarke wrote: >=20 > > * Check distinfo to make sure each file in DISTFILES has SIZE and MD5= entries > > if NO_SIZE and NO_CHECKSUM are not defined >=20 > I believe this change serves no useful purpose and should be undone: >=20 > - no rule mandates the use of SIZE in distfiles. `make makesum' adds it b= y default, > so if it is missing it is removed on purpose, e.g. to account for an mi= rror that > has an broken http server. >=20 > - the patch does not check PATCHFILES >=20 > - the check fails for DISTFILES that use :group notation >=20 > - bsd.port.mk already checks whether distinfo is consitent in terms of ex= isting MD5 > lines, no point in repeating this check in portlint >=20 > - the patch mandates SIZE lines for distfiles which are added to IGNOREFI= LES and have > MD5 (...) =3D IGNORE, which makes no sense. >=20 > Generally patches like this should be checked with portlintgrep to see wh= at ports > they flag, and whether they solve an existing or potential problem in the= ports tree. This was supposed to solve a problem that I've personally hit a few times. It was just another check to make sure PKGNAME agrees with what is in distinfo. At one time, I was thinking about PATCHFILES and the :group stuff, but I rushed 2.6.3 out for the sake of the deprecated macros. In the meantime, I've reverted the changes until I can make them work for the majority of cases. Joe >=20 > -Oliver --=20 Joe Marcus Clarke FreeBSD GNOME Team :: gnome@FreeBSD.org FreeNode / #freebsd-gnome http://www.FreeBSD.org/gnome --=-qeL1q4OifjKwIdAGI0t3 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQBAw085b2iPiv4Uz4cRAm62AJ4yE11cpyLUI+oHEjs+OYNQgZYhdwCffoGn /mNPoiIksMovcp/Wq351nwg= =bsrx -----END PGP SIGNATURE----- --=-qeL1q4OifjKwIdAGI0t3--