From owner-freebsd-hackers@freebsd.org  Mon Aug  1 14:03:00 2016
Return-Path: <owner-freebsd-hackers@freebsd.org>
Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 94086BAAC7F
 for <freebsd-hackers@mailman.ysv.freebsd.org>;
 Mon,  1 Aug 2016 14:03:00 +0000 (UTC) (envelope-from kp@FreeBSD.org)
Received: from venus.codepro.be (venus.codepro.be [IPv6:2a01:4f8:162:1127::2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits))
 (Client CN "*.codepro.be", Issuer "Gandi Standard SSL CA 2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 5416E161A
 for <freebsd-hackers@freebsd.org>; Mon,  1 Aug 2016 14:03:00 +0000 (UTC)
 (envelope-from kp@FreeBSD.org)
Received: from [192.168.228.1] (vega.codepro.be [IPv6:2a01:4f8:162:1127::3])
 (Authenticated sender: kp)
 by venus.codepro.be (Postfix) with ESMTPSA id D3BF5CCDC;
 Mon,  1 Aug 2016 16:02:56 +0200 (CEST)
From: "Kristof Provost" <kp@FreeBSD.org>
To: "Christian Mauderer" <christian.mauderer@embedded-brains.de>
Cc: "freebsd-hackers@freebsd.org" <freebsd-hackers@freebsd.org>
Subject: Re: Changes to pfctl to allow easier integration into a library
Date: Mon, 01 Aug 2016 16:02:57 +0200
Message-ID: <0C7EC45D-C3BC-4417-AF77-3ACC027D28B5@FreeBSD.org>
In-Reply-To: <cb7c6bb6-8160-3524-5432-d4ff46e16af5@embedded-brains.de>
References: <25df9fd5-be75-b9ae-aa3a-22abef3bddf0@embedded-brains.de>
 <cb7c6bb6-8160-3524-5432-d4ff46e16af5@embedded-brains.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Mailer: MailMate (2.0BETAr6042)
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers/>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Aug 2016 14:03:00 -0000

On 1 Aug 2016, at 15:03, Christian Mauderer wrote:
> Can I improve anything to make the patches more acceptable?
>
Can you explain why 
0003-pfctl-Pull-static-variables-out-of-the-function.patch is required?
I’m not sure I see why you need it.

> Is the virtualisation that Bjoern mentioned necessary or was my
> interpretation correct that this is only meant for kernel space code?
I believe your interpretations is correct.
User land code should not have to care about VIMAGE.

Regards,
Kristof