From owner-cvs-ports@FreeBSD.ORG  Thu Jun  2 16:54:02 2011
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7E530106566B;
	Thu,  2 Jun 2011 16:54:02 +0000 (UTC)
	(envelope-from wxs@atarininja.org)
Received: from syn.atarininja.org (syn.csh.rit.edu [129.21.49.45])
	by mx1.freebsd.org (Postfix) with ESMTP id 578518FC1B;
	Thu,  2 Jun 2011 16:54:02 +0000 (UTC)
Received: by syn.atarininja.org (Postfix, from userid 1001)
	id A31F45C3A; Thu,  2 Jun 2011 12:57:08 -0400 (EDT)
Date: Thu, 2 Jun 2011 12:57:08 -0400
From: Wesley Shields <wxs@FreeBSD.org>
To: cvs-src@yandex.ru
Message-ID: <20110602165708.GA61311@atarininja.org>
References: <201106021631.p52GVgHM038132@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201106021631.p52GVgHM038132@repoman.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/net/erlyvideo Makefile pkg-plist
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Jun 2011 16:54:02 -0000

On Thu, Jun 02, 2011 at 04:31:42PM +0000, Pav Lucistnik wrote:
> pav         2011-06-02 16:31:42 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     net/erlyvideo        Makefile pkg-plist 
>   Log:
>   - Fix plist
>   
>   Submitted by:   Ruslan Mahmatkhanov <cvs-src@yandex.ru> (maintainer)
>   
>   Revision  Changes    Path
>   1.7       +2 -0      ports/net/erlyvideo/Makefile
> http://cvsweb.FreeBSD.org/ports/net/erlyvideo/Makefile.diff?r1=1.6&r2=1.7
> | --- ports/net/erlyvideo/Makefile	2011/05/31 02:45:34	1.6
> | +++ ports/net/erlyvideo/Makefile	2011/06/02 16:31:42	1.7
> | @@ -2,11 +2,12 @@
> |  # Date created:                         14 January 2011
> |  # Whom:                                 Ruslan Mahmatkhanov <cvs-src@yandex.ru>
> |  #
> | -# $FreeBSD: /usr/local/www/cvsroot/FreeBSD/ports/net/erlyvideo/Makefile,v 1.6 2011/05/31 02:45:34 miwi Exp $
> | +# $FreeBSD: /usr/local/www/cvsroot/FreeBSD/ports/net/erlyvideo/Makefile,v 1.7 2011/06/02 16:31:42 pav Exp $
> |  #
> |  
> |  PORTNAME=	erlyvideo
> |  PORTVERSION=	2.8.1
> | +PORTREVISION=	1
> |  CATEGORIES=	net
> |  MASTER_SITES=	http://host5.webstroy.ru/
> |  
> | @@ -39,6 +40,7 @@ post-patch:
> |  		${WRKSRC}/priv/${PORTNAME}.conf.sample
> |  	@${FIND} ${WRKSRC} -type f -name .gitignore | ${XARGS} ${RM}
> |  	@${FIND} ${WRKSRC} -type f -name "*.bak" | ${XARGS} ${RM}
> | +	@${FIND} ${WRKSRC} -type f -name "*.orig" | ${XARGS} ${RM}
> |  	@${RMDIR} ${WRKSRC}/src/plugins

I understand Ruslan was just following the convention used in this port
but I don't like this construct. We should at least be doing -print0 |
xargs -0 if we are going to be using xargs like this. I, personally,
would prefer us to use the -delete option to find.

I wonder if there are other places in the ports tree where a similar
construct can be found that we should also cleanup.

-- WXS