From owner-cvs-all Mon Feb 3 11:50:36 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A736B37B401; Mon, 3 Feb 2003 11:50:34 -0800 (PST) Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7895143F43; Mon, 3 Feb 2003 11:50:33 -0800 (PST) (envelope-from des@ofug.org) Received: by flood.ping.uio.no (Postfix, from userid 2602) id DC1D85371; Mon, 3 Feb 2003 20:50:30 +0100 (CET) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: phk@freebsd.org Cc: Gordon Tetlow , cvs-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/geom geom_vol_ffs.c From: Dag-Erling Smorgrav Date: Mon, 03 Feb 2003 20:50:30 +0100 In-Reply-To: <11633.1044300113@critter.freebsd.dk> (phk@freebsd.org's message of "Mon, 03 Feb 2003 20:21:53 +0100") Message-ID: User-Agent: Gnus/5.090014 (Oort Gnus v0.14) Emacs/21.2 (i386--freebsd) References: <11633.1044300113@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG A couple of comments to vol_ffs: - I had to reboot for the volume names to actually appear in /dev/vol. - I was unable to set a volume name on my root partition. I tried 'tunefs -L root /dev/ad0a' in single-user mode, before mounting anything. It did not show up in /dev/vol, even after a reboot. - Although tunefs(8) won't let you set a volume label containing anything but alphanumerics (IMHO, it should accept underscores as well), there's nothing in g_vol_ffs_taste() that checks for invalid characters in the label. What happens if I manually edit the superblock and put a / in there? (imagine inserting a borrowed Zip disk and boom...) - I would be very happy if the device nodes in /dev/vol/ were actually symlinks to the underlying device - provided that's possible without introducing major ugliness into the code. DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message