From owner-freebsd-isdn  Wed Jul 14 12:58:13 1999
Delivered-To: freebsd-isdn@freebsd.org
Received: from david.siemens.de (david.siemens.de [192.35.17.14])
	by hub.freebsd.org (Postfix) with ESMTP id 78BA715448
	for <freebsd-isdn@FreeBSD.ORG>; Wed, 14 Jul 1999 12:58:08 -0700 (PDT)
	(envelope-from ust@cert.siemens.de)
X-Envelope-Sender-Is: ust@cert.siemens.de (at relayer david.siemens.de)
Received: from mail1.siemens.de (mail1.siemens.de [139.23.33.14])
	by david.siemens.de (8.9.3/8.9.3) with ESMTP id VAA21680;
	Wed, 14 Jul 1999 21:57:58 +0200 (MET DST)
Received: from mars.cert.siemens.de (ust.mchp.siemens.de [139.23.201.17])
	by mail1.siemens.de (8.9.3/8.9.3) with ESMTP id VAA02192;
	Wed, 14 Jul 1999 21:57:57 +0200 (MET DST)
Received: from alaska.cert.siemens.de (alaska.cert.siemens.de [139.23.202.134])
	by mars.cert.siemens.de (8.9.3/8.9.3/Siemens CERT [ $Revision: 1.9 ]) with ESMTP id WAA01169;
	Wed, 14 Jul 1999 22:00:16 +0200 (CEST)
Received: (from ust@localhost)
	by alaska.cert.siemens.de (8.9.3/8.9.3/alaska [ $Revision: 1.2 ]) id UAA01588;
	Wed, 14 Jul 1999 20:00:16 GMT
	(envelope-from ust)
Date: Wed, 14 Jul 1999 22:00:16 +0200
From: Udo Schweigert <ust@cert.siemens.de>
To: Markus Kurek <kurek@etecs3.uni-duisburg.de>
Cc: freebsd-isdn@FreeBSD.ORG
Subject: Re: spppcontrol do not compile on NetBSD-1.4
Message-ID: <19990714220016.A1349@alaska.cert.siemens.de>
Mail-Followup-To: Markus Kurek <kurek@etecs3.uni-duisburg.de>,
	freebsd-isdn@FreeBSD.ORG
References: <m114QRp-0003d2C@hcswork.hcs.de> <19990714200929.A24440@etecs3.uni-duisburg.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 0.95.6i
In-Reply-To: <19990714200929.A24440@etecs3.uni-duisburg.de>; from Markus Kurek on Wed, Jul 14, 1999 at 08:09:29PM +0200
X-Operating-System: FreeBSD 3.2-STABLE
Sender: owner-freebsd-isdn@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

On Wed, Jul 14, 1999 at 08:09:29PM +0200, Markus Kurek wrote:
> On Wed, Jul 14, 1999 at 04:55:49PM +0200, Hellmuth Michaelis wrote:
> > 
> > a new isdn4bsd beta version (i4b-00.82.00-beta-140799.tar.gz) has been made
> > available on the isdn4bsd distribution site.
> > 
> I tried upgrading my system to the new beta.
> 
> cc -O2 -g -Wall -I.. -Werror   -c spppcontrol.c
> In file included from spppcontrol.c:61:
> ../if_sppp.h:110: field `pp_comp' has incomplete type
> 
> 
> This is on NetBSD-1.4.
> 
> Any hints ?
> 

This is a problem due to VJ compression, which is new in sppp.

In spppcontrol.c we have at lines 50-58:

#ifdef __FreeBSD__
#if  __FreeBSD__ >= 3
#include <net/if_var.h>
#endif
#include <netinet/in.h>
#include <netinet/in_systm.h>
#include <netinet/ip.h>
#include <net/slcompress.h>
#endif

Here we should have the appropriate #includes for non-FreeBSD; an inspection
of i4b_ipr.c shows that something like this could be sufficient:

#ifdef __FreeBSD__
#if  __FreeBSD__ >= 3
#include <net/if_var.h>
#endif
#include <netinet/in.h>
#include <netinet/in_systm.h>
#else
#include <netinet/in.h>
#include <netinet/in_systm.h>
#include <netinet/in_var.h>
#endif
#include <netinet/ip.h>
#include <net/slcompress.h>

Maybe you can verify/correct this solution.

Regards
-------------------------------------------------------------------------------
Udo Schweigert              || Voice      : +49 89 636 42170
Siemens AG, Siemens CERT    || Fax        : +49 89 636 48000
ZT IK 3                     || email      : Udo.Schweigert@mchp.siemens.de
D-81730 Muenchen / Germany  ||            : ust@cert.siemens.de
PGP fingerprint             || 2A 53 F6 A6 30 59 64 02  6B C4 E0 73 B2 C9 6C E7
-------------------------------------------------------------------------------


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-isdn" in the body of the message