From owner-freebsd-current@FreeBSD.ORG  Tue Aug  5 12:34:22 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D205137B404
	for <freebsd-current@freebsd.org>;
	Tue,  5 Aug 2003 12:34:22 -0700 (PDT)
Received: from phk.freebsd.dk (phk.freebsd.dk [212.242.86.175])
	by mx1.FreeBSD.org (Postfix) with ESMTP id ECEDF43FF3
	for <freebsd-current@freebsd.org>;
	Tue,  5 Aug 2003 12:34:16 -0700 (PDT)
	(envelope-from phk@phk.freebsd.dk)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by phk.freebsd.dk (8.12.8/8.12.8) with ESMTP id h75JXVV3016022;
	Tue, 5 Aug 2003 19:33:32 GMT
	(envelope-from phk@phk.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h75JXUPI034415;
	Tue, 5 Aug 2003 21:33:31 +0200 (CEST)
	(envelope-from phk@phk.freebsd.dk)
To: Rob <rob@debank.tv>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Tue, 05 Aug 2003 21:23:45 +0200."
             <3F300441.1040904@debank.tv> 
Date: Tue, 05 Aug 2003 21:33:30 +0200
Message-ID: <34414.1060112010@critter.freebsd.dk>
cc: freebsd-current@freebsd.org
Subject: Re: vinum problems with todays current 
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Aug 2003 19:34:23 -0000

In message <3F300441.1040904@debank.tv>, Rob writes:
>Hi all,
>
>After cvs'upping (about 12 hours ago) and building world/kernel vinum 
>stopped working. It does show my two disks but nothing more. I also 
>get an error message right after the bootloader:

Can you try this patch:


Index: spec_vnops.c
===================================================================
RCS file: /home/ncvs/src/sys/fs/specfs/spec_vnops.c,v
retrieving revision 1.206
diff -u -r1.206 spec_vnops.c
--- spec_vnops.c	5 Aug 2003 06:43:56 -0000	1.206
+++ spec_vnops.c	5 Aug 2003 19:33:06 -0000
@@ -505,9 +505,9 @@
 	   devtoname(bp->b_dev), bp));
 	
 	if ((dsw->d_flags & D_NOGIANT) && !(bp->b_flags & B_KEEPGIANT)) {
-		DROP_GIANT();
+		/* DROP_GIANT(); */
 		DEV_STRATEGY(bp);
-		PICKUP_GIANT();
+		/* PICKUP_GIANT(); */
 	} else
 		DEV_STRATEGY(bp);
 		

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.