From owner-freebsd-ports@FreeBSD.ORG Wed Feb 22 18:47:38 2012 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7325D1065670; Wed, 22 Feb 2012 18:47:38 +0000 (UTC) (envelope-from rhurlin@gwdg.de) Received: from fmailer.gwdg.de (fmailer.gwdg.de [134.76.11.16]) by mx1.freebsd.org (Postfix) with ESMTP id 0AC428FC1D; Wed, 22 Feb 2012 18:47:37 +0000 (UTC) Received: from p579189f1.dip.t-dialin.net ([87.145.137.241] helo=krabat.raven.hur) by mailer.gwdg.de with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.72) (envelope-from ) id 1S0HE0-0002Wy-Dd; Wed, 22 Feb 2012 19:47:36 +0100 Message-ID: <4F453843.3030805@gwdg.de> Date: Wed, 22 Feb 2012 19:47:31 +0100 From: Rainer Hurling User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:10.0.2) Gecko/20120218 Thunderbird/10.0.2 MIME-Version: 1.0 To: Doug Barton References: <4F3F94C5.5020005@gwdg.de> <4F4021CF.9030503@FreeBSD.org> <4F409850.2010404@gwdg.de> In-Reply-To: <4F409850.2010404@gwdg.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated: Id:rhurlin X-Spam-Level: - X-Virus-Scanned: (clean) by exiscan+sophie Cc: freebsd-ports@freebsd.org Subject: Re: x11-wm/windowmaker: saving session not possible any more X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Feb 2012 18:47:38 -0000 On 19.02.2012 07:36 (UTC+1), Rainer Hurling wrote: > On 18.02.2012 23:10 (UTC+1), Doug Barton wrote: >> On 02/18/2012 04:08, Rainer Hurling wrote: >>> Many thanks for the update of WindowMaker. I really appreciate it! As >>> far as I was able to test until now it works greats. >>> >>> The only problem I run into is, that it is not possible to save the >>> workspaces (sessions) any more. With prior versions I was able to save >>> opened xterms or other windows on serveral workspaces (menu workspace: >>> save session) and restore them when starting WindowMaker again. >>> >>> Is it only me having this problem or is there something wrong with the >>> new port (or even the sources)? >> >> I tried this myself (I don't usually use that option) and your report >> seems to be accurate. I bcc'ed you on a message to the wmaker-dev list, >> we'll see what they have to say. Feel free to subscribe yourself if >> you'd like to join in. > > Thank you for taking time for this. I will follow the discussion over > > http://news.gmane.org/gmane.compw.window-managers.windowmaker.devel > > and only subscribe if I have something to contribute. Hi Doug, it seems I found a workaround for getting the session restored after restarting windowmaker. Commenting out a flag in src/startup.c does it: --- src/startup.c.orig 2012-02-14 20:36:01.000000000 +0100 +++ src/startup.c 2012-02-22 19:20:43.000000000 +0100 @@ -761,7 +761,8 @@ wMenuRestoreState(wScreen[j]); /* If we're not restarting, restore session */ - if (wPreferences.flags.restarting == 0 && !wPreferences.flags.norestore) + if (wPreferences.flags.restarting == 0) + /* && !wPreferences.flags.norestore) */ wSessionRestoreState(wScreen[j]); if (!wPreferences.flags.noautolaunch) { I seems to be sufficient to comment out either the first term (wPreferences.flags.restarting == 0), or the second term (!wPreferences.flags.norestore). In both cases restoring the session work. Only both at once (with &&) does not work. I have no clue what is going wrong here. Perhaps you have an idea? Should we make a patch for that as a workaround? Greetings, Rainer > Rainer > > >> Doug