From owner-cvs-all Mon Feb 3 12:10:30 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E14EA37B401; Mon, 3 Feb 2003 12:10:28 -0800 (PST) Received: from ns2.gnf.org (ns2.gnf.org [63.196.132.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2BA8343FA3; Mon, 3 Feb 2003 12:10:27 -0800 (PST) (envelope-from gtetlow@gnf.org) Received: from EXCHCLUSTER01.lj.gnf.org (exch01.lj.gnf.org [172.25.10.19]) by ns2.gnf.org (8.12.3/8.12.3) with ESMTP id h13KAOtk076639; Mon, 3 Feb 2003 12:10:24 -0800 (PST) (envelope-from gtetlow@gnf.org) Received: from roark.gnf.org ([172.25.24.15]) by EXCHCLUSTER01.lj.gnf.org with Microsoft SMTPSVC(5.0.2195.5329); Mon, 3 Feb 2003 12:10:26 -0800 Received: from roark.gnf.org (localhost [127.0.0.1]) by roark.gnf.org (8.12.6/8.12.6) with ESMTP id h13KAQGj061069; Mon, 3 Feb 2003 12:10:26 -0800 (PST) (envelope-from gtetlow@gnf.org) Received: (from gtetlow@localhost) by roark.gnf.org (8.12.6/8.12.6/Submit) id h13KAQxv061068; Mon, 3 Feb 2003 12:10:26 -0800 (PST) Date: Mon, 3 Feb 2003 12:10:26 -0800 From: Gordon Tetlow To: Dag-Erling Smorgrav Cc: phk@freebsd.org, cvs-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/geom geom_vol_ffs.c Message-ID: <20030203201026.GD98559@roark.gnf.org> References: <11633.1044300113@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="VMt1DrMGOVs3KQwf" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4i X-OriginalArrivalTime: 03 Feb 2003 20:10:26.0913 (UTC) FILETIME=[4AD07510:01C2CBC0] Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --VMt1DrMGOVs3KQwf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 03, 2003 at 08:50:30PM +0100, Dag-Erling Smorgrav wrote: > A couple of comments to vol_ffs: >=20 > - I had to reboot for the volume names to actually appear in /dev/vol. >=20 > - I was unable to set a volume name on my root partition. I tried > 'tunefs -L root /dev/ad0a' in single-user mode, before mounting > anything. It did not show up in /dev/vol, even after a reboot. This is because you opened another device underneath the volume name device. This causes a spoil event to kill the volume name device. If you were to put /dev/vol/rootfs in your fstab, it'll work but it takes some faith. I had the same experience on my laptop. > - Although tunefs(8) won't let you set a volume label containing > anything but alphanumerics (IMHO, it should accept underscores as > well), there's nothing in g_vol_ffs_taste() that checks for invalid > characters in the label. What happens if I manually edit the > superblock and put a / in there? (imagine inserting a borrowed Zip > disk and boom...) I've got a commit in my tree that adds a comment about this. It's on my TODO list. I was thinking of adding . as a valid character as well (but disallowing leading periods for security reasons). -gordon --VMt1DrMGOVs3KQwf Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE+PsyyRu2t9DV9ZfsRAuxVAKCVKTxUkj8RCTspHlOSBvLzvI4EmACgusFz vqpcrEkpzLu6OfZys5CoxhY= =Tz6c -----END PGP SIGNATURE----- --VMt1DrMGOVs3KQwf-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message