From owner-cvs-ports@FreeBSD.ORG Thu Mar 22 17:49:12 2012 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2FE711065674; Thu, 22 Mar 2012 17:49:12 +0000 (UTC) (envelope-from scheidell@freebsd.org) Received: from mx2.secnap.com.ionspam.net (mx2.secnap.com.ionspam.net [216.134.223.54]) by mx1.freebsd.org (Postfix) with ESMTP id ECAE78FC18; Thu, 22 Mar 2012 17:49:11 +0000 (UTC) Received: from mx2.secnap.com.ionspam.net (unknown [10.71.0.54]) by mx2.secnap.com.ionspam.net (Postfix) with ESMTP id 19CE1D23C03; Thu, 22 Mar 2012 13:49:05 -0400 (EDT) X-Virus-Scanned: SpammerTrap(r) VPS-1500 2.18 at mx2.secnap.com.ionspam.net Received: from USBCTDC001.secnap.com (unknown [10.70.1.1]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mx2.secnap.com.ionspam.net (Postfix) with ESMTPS id A53BED23C01; Thu, 22 Mar 2012 13:49:03 -0400 (EDT) Received: from macintosh.secnap.com (10.70.3.3) by USBCTDC001.secnap.com (10.70.1.1) with Microsoft SMTP Server (TLS) id 14.0.722.0; Thu, 22 Mar 2012 13:49:02 -0400 Message-ID: <4F6B660E.5080205@freebsd.org> Date: Thu, 22 Mar 2012 13:49:02 -0400 From: Michael Scheidell Organization: SECNAP Network Security Corp User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.20) Gecko/20110804 Thunderbird/3.1.12 MIME-Version: 1.0 To: Doug Barton References: <201203191403.q2JE3sM8051201@repoman.freebsd.org> <20120319143041.GB27552@atarininja.org> <4F67438C.605@freebsd.org> <20120320022942.GC27552@atarininja.org> <4F67FCF1.807@FreeBSD.org> In-Reply-To: <4F67FCF1.807@FreeBSD.org> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, Wesley Shields , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/graphics/opennurbs Makefile pkg-plist X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Mar 2012 17:49:12 -0000 On 3/19/12 11:43 PM, Doug Barton wrote: > On 3/19/2012 7:29 PM, Wesley Shields wrote: >> On Mon, Mar 19, 2012 at 10:32:44AM -0400, Michael Scheidell wrote: >>>> >>>> On 3/19/12 10:30 AM, Wesley Shields wrote: >>>>>> Isn't it better to use ${INSTALL_DATA} here? >>>>>> >>>>>> -- WXS >>>> open a pr, let maintainer approve it. >> As the person who committed this it is your responsibility to see that >> issues raised are properly fixed. If you feel like the maintainer should >> be brought in for such a simple change that is your decision to make, >> but I shouldn't have to open a PR to address this. > +1 > > yeh doug, like this one? which I sent to you privately, after you editied makefile and redid how PORTDOCS worked by changing it to the macro? weren't you the last committer? oh, and not only the last committer, but you wrote the actual patch! Look what you left on the filesystem after pkg deleted because you didn't look at the Makefile and see the obvious mistake: Don't you ever test your patches first? Have some common courtesy, all of you. I will continue to privately send a patch to a member of our team, and, offer to open a PR if they insist. (i opened a pr March 3rd, after sending Doug a private email on Feb 27th. He finally got back to me and told me to open a pr.. I didn't send a public flogging email demanding that at the last committer he fix it, and, I would not have, hoping that by example, he would maybe learn that a quick, private email, with a patch, or suggestion, or real explanation of the problem was better than public flogging. Even if I get cryptic emails demanding I fix something and am never told what it broke. When it actually does break something, I make it a priority to fix it, and if you have seen my lead time on real emergencies, its, like, what, 5 mins after the tinderbox got finished with it? I am sorry that the mv inserted by the maintainer caused such an international incident, maybe someone should edit portlint and look for ${MV} or \bmv\b ? No, stop wasting time, and start back to making FreeBSD the best choice, best operating system for discriminating system admins. -- Michael Scheidell, CTO >*| * SECNAP Network Security Corporation d: +1.561.948.2259 w: http://people.freebsd.org/~scheidell