From owner-svn-src-all@freebsd.org Mon Aug 15 14:00:37 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D25E9BBB35A; Mon, 15 Aug 2016 14:00:37 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail110.syd.optusnet.com.au (mail110.syd.optusnet.com.au [211.29.132.97]) by mx1.freebsd.org (Postfix) with ESMTP id 9D8841BAF; Mon, 15 Aug 2016 14:00:36 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from c122-106-149-109.carlnfd1.nsw.optusnet.com.au (c122-106-149-109.carlnfd1.nsw.optusnet.com.au [122.106.149.109]) by mail110.syd.optusnet.com.au (Postfix) with ESMTPS id 4499E785D5B; Mon, 15 Aug 2016 23:40:50 +1000 (AEST) Date: Mon, 15 Aug 2016 23:40:49 +1000 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Shawn Webb cc: Bruce Evans , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r304153 - head/sys/dev/syscons In-Reply-To: <20160815131600.GA86798@mutt-hardenedbsd> Message-ID: <20160815231956.X2752@besplex.bde.org> References: <201608151256.u7FCujHw048832@repo.freebsd.org> <20160815131600.GA86798@mutt-hardenedbsd> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.1 cv=VIkg5I7X c=1 sm=1 tr=0 a=R/f3m204ZbWUO/0rwPSMPw==:117 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=kj9zAlcOel0A:10 a=Pl7VVdGIrsZcu9rEHXcA:9 a=CjuIK1q_8ugA:10 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Aug 2016 14:00:37 -0000 On Mon, 15 Aug 2016, Shawn Webb wrote: > On Mon, Aug 15, 2016 at 12:56:45PM +0000, Bruce Evans wrote: >> >> Log: >> Quick fix for locking fixes in r172250. The lock added there was per- >> virtual-device, but needs to be per-physical-device so that it protects >> shared data. Usually, scp->sc->write_in_progress got corrupted first >> and further corruption was limited when this variable was left at nonzero >> with no write in progress. > ... > > Should this be MFC'd after some point? Possibly. This is a small part of ~60K of patches for locking bugs in console drivers (only ones that I use, syscons and sio) and subr_prf.c and subr_msgbuf.c. It is meant to be safe and easy to merge by itself, but I have too many little patches to merge one at a time. Bruce