From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Jan 5 12:50:02 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E7EF0106566C for ; Mon, 5 Jan 2009 12:50:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id C4BB68FC17 for ; Mon, 5 Jan 2009 12:50:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n05Co1TV081628 for ; Mon, 5 Jan 2009 12:50:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n05Co1rQ081627; Mon, 5 Jan 2009 12:50:01 GMT (envelope-from gnats) Resent-Date: Mon, 5 Jan 2009 12:50:01 GMT Resent-Message-Id: <200901051250.n05Co1rQ081627@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Artis Caune Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 80265106566C for ; Mon, 5 Jan 2009 12:45:51 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 6F0218FC0C for ; Mon, 5 Jan 2009 12:45:51 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n05Cjp4t025100 for ; Mon, 5 Jan 2009 12:45:51 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n05Cjohs025099; Mon, 5 Jan 2009 12:45:50 GMT (envelope-from nobody) Message-Id: <200901051245.n05Cjohs025099@www.freebsd.org> Date: Mon, 5 Jan 2009 12:45:50 GMT From: Artis Caune To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/130184: [patch] mail/exim: fix user/group creation order and errors X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Jan 2009 12:50:02 -0000 >Number: 130184 >Category: ports >Synopsis: [patch] mail/exim: fix user/group creation order and errors >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Jan 05 12:50:01 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Artis Caune >Release: stable/7 >Organization: >Environment: FreeBSD builder 7.1-STABLE FreeBSD 7.1-STABLE #0 r186761: Mon Jan 5 11:46:44 EET 2009 root@builder:/usr/obj/usr/src/sys/GENERIC amd64 >Description: - If using EXIM_USER and EXIM_GROUP with packages, install script will fail because it will first try to add user and then group. You can not add user without existing group. - Install script use ${EXIM_USER}, ${EXIM_GROUP} variables, which are only used in ports, not packages. >How-To-Repeat: # make EXIM_USER=exim EXIM_GROUP=exim package clean # pkg_delete exim-4.69_2 # pw group del exim # pw user del exim # pkg_add ./exim-4.69_2.tbz >Fix: Patch attached with submission follows: --- pkg-install.orig 2007-08-04 14:41:00.000000000 +0300 +++ pkg-install 2009-01-05 14:29:08.999104684 +0200 @@ -18,12 +18,12 @@ logdir=%%LOGDIR%% if [ "$2" = "PRE-INSTALL" ]; then - if ! /usr/bin/id ${user} > /dev/null; then - /usr/sbin/pw useradd ${EXIM_USER} -g ${EXIM_GROUP} -u 125 \ - -h - -d /var/spool/exim -s /nonexistent -c "Exim User" + if ! /usr/sbin/pw groupshow ${group} >/dev/null; then + /usr/sbin/pw groupadd ${group} -g 125 fi - if ! /usr/bin/grep -q "^${group}:" /etc/group; then - /usr/sbin/pw groupadd ${EXIM_GROUP} -g 125 + if ! /usr/sbin/pw usershow ${user} >/dev/null; then + /usr/sbin/pw useradd ${user} -g ${group} -u 125 \ + -h - -d /var/spool/exim -s /nonexistent -c "Exim User" fi /bin/mkdir -p ${logdir} /usr/sbin/chown ${user}:${group} ${logdir} >Release-Note: >Audit-Trail: >Unformatted: