From owner-freebsd-current@FreeBSD.ORG  Fri May 19 00:02:19 2006
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from localhost.my.domain (localhost [127.0.0.1])
	by hub.freebsd.org (Postfix) with ESMTP id ABFC416A403;
	Fri, 19 May 2006 00:02:18 +0000 (UTC)
	(envelope-from davidxu@freebsd.org)
From: David Xu <davidxu@freebsd.org>
To: Rostislav Krasny <rosti.bsd@gmail.com>
Date: Fri, 19 May 2006 08:02:08 +0800
User-Agent: KMail/1.8.2
References: <20060430142408.fcd60069.rosti.bsd@gmail.com>
	<44554601.5090105@freebsd.org>
	<20060519023732.ea4221dd.rosti.bsd@gmail.com>
In-Reply-To: <20060519023732.ea4221dd.rosti.bsd@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200605190802.08825.davidxu@freebsd.org>
Cc: is@rambler-co.ru, Colin Percival <cperciva@freebsd.org>,
	freebsd-current@freebsd.org
Subject: Re: FreeBSD-SA-06:14.fpu
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 19 May 2006 00:02:19 -0000

On Friday 19 May 2006 07:37, Rostislav Krasny wrote:
> On Sun, 30 Apr 2006 16:19:29 -0700
>
> Colin Percival <cperciva@freebsd.org> wrote:
> > Rostislav Krasny wrote:
> > > Other possible solution is making the fpu_clean_state() optional by
> > > something like following:
> > >
> > > #ifdef BUG_FXSAVE
> > > #define fpu_clean_state() __fpu_clean_state()
> > > #else
> > > #define fpu_clean_state() ;
> > > #endif
> > >
> > > ... and including "options BUG_FXSAVE" to GENERIC.
> >
> > Yes, this is probably the right solution.  My priority was to fix the
> > bug; optimizing performance comes second.
>
> Ok. Is this solution going to be done some day? I could try to make a
> patch but I'm not familiar with the build infrastructure internals.
>
> P.S. what is a better option name: "options BUG_FXSAVE" or "options
> AMD_FXSAVE"?

Patch is welcome, but I would call it BUG_FXSAVE like Linux's select()
changed timeout value which only added incompatibility rather than
advantage.

David Xu